Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtask of #33: Update 'No-Redux' option #227

Closed
phmngocnghia opened this issue Feb 11, 2020 · 0 comments
Closed

Subtask of #33: Update 'No-Redux' option #227

phmngocnghia opened this issue Feb 11, 2020 · 0 comments
Assignees
@dannd4
Labels
front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Milestone
Foundations Alpha...

Comments

@phmngocnghia
Copy link
Contributor

Base PR: #224

  • Update new auth flow to 'No-redux' section. There is a folder named 'no-redux'
  • Remove related redux files: actions/reducer...
  • Update base components to work without redux
  • Use 'Context' to manage auth state

Tips:
You may want to scaffolder a project first, update it and finally reflect the changes to the scaffolder
@phmngocnghia phmngocnghia changed the title Subtask of #33: Add 'No-Redux' option Subtask of #33: Update 'No-Redux' option Feb 11, 2020
@duong-se duong-se assigned duong-se and dannd4 and unassigned duong-se Feb 12, 2020
dannd4 pushed a commit that referenced this issue Feb 13, 2020
chore: #227: scaffolder option no redux
6874063
willmcvay pushed a commit that referenced this issue Feb 13, 2020
@dannd4
chore: #227: scaffolder option no redux (#268)
de461f2
@willmcvay willmcvay added front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package labels Feb 13, 2020
phmngocnghia pushed a commit that referenced this issue Feb 14, 2020
@dannd4 @phmngocnghia
chore: #227: scaffolder option no redux (#268)
caf0856
phmngocnghia pushed a commit that referenced this issue Feb 14, 2020
@dannd4 @phmngocnghia
chore: #227: scaffolder option no redux (#268)
a09d9bb
willmcvay pushed a commit that referenced this issue Feb 14, 2020
@trankhacvy @dannd4
[WIP]Chore/33 update react scalfolder (#224)
03e2db4 
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@vuhuucuong
[CLD 574] Term and condition when developer submit an app (#227)
d63f551 
* [CLD-574] As a ‘Developer’, when I Submit an App, I want to tick a box to agree to the Terms and Conditions
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
[CLD-720]Add the utility class: mw-100, add max-width: 100% to .conta…
ee33e7c 
…iner (#227) (#228)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy @dannd4
[WIP]Chore/33 update react scalfolder (#224)
f90cefe 
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
@rpt-uk-github rpt-uk-github mentioned this issue Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannd4 dannd4

Labels
front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
Foundations Alpha Developer Release
Development

No branches or pull requests
4 participants
@willmcvay @duong-se @phmngocnghia @dannd4