Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge unused code from developer portal #1917

Closed
willmcvay opened this issue Jul 1, 2020 · 0 comments · Fixed by #2004, #2005, #2007, #2029 or #2036
Closed

Purge unused code from developer portal #1917

willmcvay opened this issue Jul 1, 2020 · 0 comments · Fixed by #2004, #2005, #2007, #2029 or #2036
Assignees
@nphivu414
Labels
chore Maintenance or housekeeping tasks developer-portal front-end Relates to front end issues
Milestone
Developer Portal ...

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

Depends on #1821. Developer portal is now a standalone app but is a clone of Marketplace. As such, need to strip out old marketplace code so only relevant code remains

Specification or Acceptance Criteria:

  • All non developer portal code is removed from project, including TS, CSS, Scripts, Fonts, Assets
  • All non-relevant NPM modules are removed from package manifest
  • Deploy this new app to dev and ensure no regressions
@willmcvay willmcvay added chore Maintenance or housekeeping tasks front-end Relates to front end issues developer-portal labels Jul 1, 2020
@nphivu414 nphivu414 self-assigned this Jul 7, 2020
nphivu414 pushed a commit that referenced this issue Jul 8, 2020
fix: #1917 Purge unused code from login page
456cf08
@nphivu414 nphivu414 mentioned this issue Jul 8, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 8, 2020
fix: #1917 Fix lint errors
359ed80
nphivu414 pushed a commit that referenced this issue Jul 8, 2020
fix: #1917 Purge unused code from login page in developer portal (#2004)
86f9f39 
* fix: #1917 Purge unused code from login page
nphivu414 pushed a commit that referenced this issue Jul 8, 2020
feat: #1917 Remove unused code from register page in dev portal
ff0000d
@nphivu414 nphivu414 mentioned this issue Jul 8, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 8, 2020
feat: #1917 Purge unused code from register page in dev portal
cddad44
@nphivu414 nphivu414 mentioned this issue Jul 8, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feat: #1917 Remove unused code from register page in dev portal (#2005)
d9bec10
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feat: #1917 Purge unused code from register page in dev portal (#2007)
b2b8fb8
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feature: #1917 Remove client app detail files and update dev app deta…
fc01c2a 
…il file names
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feature: #1917 Restructure app detail folders
b0d356a
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feature: #1917 Restructure app detail folders
0a6d78e
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
feature: #1917 Update tests
c575c89
@nphivu414 nphivu414 mentioned this issue Jul 10, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 10, 2020
feat: #1917 Revert missing files from marketplaces
d8b14f2
nphivu414 pushed a commit that referenced this issue Jul 10, 2020
feat: #1917 Update tests
a0995c2
nphivu414 pushed a commit that referenced this issue Jul 10, 2020
feat: #1917 Restructure developer analytics page
d1ee2dd
nphivu414 pushed a commit that referenced this issue Jul 10, 2020
feat: #1917 purge unused code from dev portal webhooks page (#2037)
b1b7a38 
* feat: #1917 Restructure webhook folders

* feat: #1917 Restructure webhook folders

* feat: #1917 Update tests
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Purge unused code from settings page
c0d86e3
@nphivu414 nphivu414 mentioned this issue Jul 13, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Purge unused code from settings page (#2043)
7f762a1
@nphivu414 nphivu414 mentioned this issue Jul 13, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Removed unused routes and redux files
488eedf
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Update variable name for more meaningful
c4bfd04
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 purge unused code from all remaining pages in dev portal (#…
ab629ac 
…2046)
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Fix test issues
50d90db
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Merge master and fix conflicts
2f05308
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Remove myApps from redux store
7b672e2
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Update tests
caee82a
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Update tests
f4d71d6
nphivu414 pushed a commit that referenced this issue Jul 13, 2020
feat: #1917 Fix menu issues
dbbec14
nphivu414 pushed a commit that referenced this issue Jul 14, 2020
feat: #1917 Fix conflicts with master
0fbe679
nphivu414 pushed a commit that referenced this issue Jul 14, 2020
feature: #1917 Fix missing dev edition route issues
7f56e46
@nphivu414 nphivu414 mentioned this issue Jul 14, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 14, 2020
feat: #1917 Remove all unused routes and redux code in dev portal (#2059
63b67df 
)
nphivu414 pushed a commit that referenced this issue Jul 15, 2020
feat: #1917 Update developer preview app page
96f0fd1
nphivu414 pushed a commit that referenced this issue Jul 15, 2020
feat: #1917 Update tests + remove unused files
ddeb6e3
nphivu414 pushed a commit that referenced this issue Jul 15, 2020
feat: #1917 Update comments
fb3fa8e
@nphivu414 nphivu414 mentioned this issue Jul 15, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 16, 2020
feat: #1917 Fix issues based on reviews
d0d406d
nphivu414 pushed a commit that referenced this issue Jul 16, 2020
feat: #1917 Remove unused code
98a0212
nphivu414 pushed a commit that referenced this issue Jul 16, 2020
feat: #1917 Update default destroyOnClose prop of ModalV2 to true
1f2c96f
nphivu414 pushed a commit that referenced this issue Jul 16, 2020
feat: #1917 Rework developer preview app (#2066)
eab694e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphivu414 nphivu414

Labels
chore Maintenance or housekeeping tasks developer-portal front-end Relates to front end issues
Projects
None yet
Milestone
Developer Portal Production Release
Development

Successfully merging a pull request may close this issue.

fix: #1917 Purge unused code from login page in developer portal reapit/foundations
feat: #1917 Remove unused code from register page in dev portal reapit/foundations
feat: #1917 Purge unused code from apps page in dev portal reapit/foundations
feat: #1917 purge unused code from dev portal app detail page reapit/foundations
feat: #1917 purge unused code from dev portal analytics page reapit/foundations
feat: #1917 purge unused code from dev portal webhooks page reapit/foundations
feat: #1917 Purge unused code from settings page reapit/foundations
feat: #1917 purge unused code from all remaining pages in dev portal reapit/foundations
feat: #1917 Remove all unused routes and redux code in dev portal reapit/foundations
feat: #1917 Rework developer preview app reapit/foundations
2 participants
@willmcvay @nphivu414