feat: #1917 Rework developer preview app #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 15, 2020 11:15
…eat/1917-rework-developer-preview-app
trankhacvy
approved these changes
Jul 15, 2020
duong-se
reviewed
Jul 15, 2020
| return ( | ||
| <Grid dataTest="client-app-detail-container"> | ||
| {!appDetailPreviewData ? ( | ||
| <Loader dataTest="client-app-detail-loader" /> |
There was a problem hiding this comment.
I think this place should show message There is no preview app or something like that, just show loader when it load data from BE
duong-se
reviewed
Jul 15, 2020
| isInstallBtnHidden, | ||
| }) => { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
Could you change to use if return here ?
duong-se
reviewed
Jul 15, 2020
| NEED HELP? | ||
| </Button> | ||
|
|
||
| <Modal |
duong-se
reviewed
Jul 15, 2020
| import styles from '@/styles/blocks/app-authentication-detail.scss?mod' | ||
| import { Loader, Content, H5 } from '@reapit/elements' | ||
| import { FaCopy } from 'react-icons/fa' | ||
| import { CopyToClipboard } from 'react-copy-to-clipboard' |
There was a problem hiding this comment.
could you change to import CopyToClipboard from 'react-copy-to-clipboard' instead. After my PR merge it'll be break CI
added 2 commits
July 16, 2020 10:08
…eat/1917-rework-developer-preview-app
duong-se
approved these changes
Jul 16, 2020
duong-se
reviewed
Jul 16, 2020
| visible={visible} | ||
| title={'Contact Details'} | ||
| afterClose={closeContactModal(setVisible)} | ||
| footerItems={ | ||
| onClose={closeContactModal(setVisible)} |
There was a problem hiding this comment.
pls add destroyOnClose={true}
github-actions
bot
added
the
elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1917
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1917
What is the new behavior?
Does this introduce a breaking change?
Other information