Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1917 Purge unused code from login page in developer portal #2004

Merged
merged 2 commits into from
Jul 8, 2020
Merged

fix: #1917 Purge unused code from login page in developer portal #2004

merged 2 commits into from
Jul 8, 2020

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1917

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1917

What is the new behavior?

  • Purge unused code from login page in developer portal

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from duong-se and vuhuucuong July 8, 2020 06:45
@auto-assign auto-assign bot requested review from phmngocnghia and willmcvay July 8, 2020 06:46
duong-se
duong-se approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested review from duong-se and trankhacvy July 8, 2020 07:21
@nphivu414 nphivu414 merged commit 86f9f39 into master Jul 8, 2020
@nphivu414 nphivu414 deleted the feat/1917-purge-unused-code-from-dev-portal-login-page branch July 8, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@willmcvay willmcvay Awaiting requested review from willmcvay

@duong-se duong-se Awaiting requested review from duong-se

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

Assignees

@nphivu414 nphivu414

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purge unused code from developer portal
3 participants
@nphivu414 @duong-se @phmngocnghia