Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer or client, I should be able to view an app in a standalone page #1125

Closed
willmcvay opened this issue Apr 30, 2020 · 0 comments · Fixed by #1240
Closed

As a developer or client, I should be able to view an app in a standalone page #1125

willmcvay opened this issue Apr 30, 2020 · 0 comments · Fixed by #1240
Assignees
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

Currently, as a user client or developer, I view app details in a modal. These modals have grown too small for their use case so require a standalone app page

Specification or Acceptance Criteria:

  • I should be able to view the same app details shown in the modal on the client/manage client/apps and developer/apps pages in standalone pages by creating client/apps/:id and developer/apps/:id routes.
  • Currently we just want to render the exact content we have in the modals in a 2 column grid (desktop), 1/3 / 2/3 split - see: https://github.com/marketplace/rollbar for an example layout.
  • Detail rendered above the carousel to be in the left column, detail rendered below and including the carousel in the right hand column.
  • In tablet and below, the left column should stack above the right column and both be full width
  • UI enhancements will be on a second ticket @HollyJoyPhillips to provide.
  • Routing too and from these pages should be by direct load of the URL now. Modal functionality should be maintained until the pages are finished (second routing ticket @willmcvay to provide)
  • Description field should render HTML see As a developer, I should be able to enhance my app listing description with HTML #1123
@willmcvay willmcvay added feature New feature or request marketplace Relates to the Marketplace front-end Relates to front end issues labels Apr 30, 2020
@nphivu414 nphivu414 self-assigned this May 4, 2020
nphivu414 added a commit that referenced this issue May 6, 2020
nphivu414 added a commit that referenced this issue May 12, 2020
nphivu414 added a commit that referenced this issue May 13, 2020
@nphivu414 nphivu414 linked a pull request May 13, 2020 that will close this issue
nphivu414 added a commit that referenced this issue May 13, 2020
nphivu414 added a commit that referenced this issue May 14, 2020
nphivu414 added a commit that referenced this issue May 14, 2020
* feat: #1125: Create app details standalone page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants