feat: #1125: Update uninstall app modal rendeing flow

reapit · May 14, 2020 · acf7726 · acf7726
1 parent 5e83048
commit acf7726
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 42 deletions.
diff --git a/...es/client-app-detail-manage/__test__/__snapshots__/client-app-detail-manage.test.tsx.snap b/...es/client-app-detail-manage/__test__/__snapshots__/client-app-detail-manage.test.tsx.snap
@@ -161,43 +161,6 @@ exports[`ClientAppDetailManage should match a snapshot 1`] = `
               </div>
             </Component>
           </AppContent>
-          <ClientAppUninstallConfirmation
-            appDetailData={Object {}}
-            closeUninstallConfirmationModal={[Function]}
-            visible={false}
-          >
-            <Component
-              afterClose={[Function]}
-              footerItems={
-                <React.Fragment>
-                  <Unknown
-                    dataTest="agree-btn"
-                    loading={false}
-                    onClick={[Function]}
-                    type="button"
-                    variant="primary"
-                  >
-                    Confirm
-                  </Unknown>
-                  <Unknown
-                    dataTest="disagree-btn"
-                    disabled={false}
-                    onClick={[Function]}
-                    type="button"
-                    variant="danger"
-                  >
-                    Cancel
-                  </Unknown>
-                </React.Fragment>
-              }
-              title="Confirm undefined installation"
-              visible={false}
-            />
-            <Component
-              afterClose={[Function]}
-              visible={false}
-            />
-          </ClientAppUninstallConfirmation>
         </div>
       </ClientAppDetailManage>
     </Router>

diff --git a/...es/marketplace/src/components/pages/client-app-detail-manage/client-app-detail-manage.tsx b/...es/marketplace/src/components/pages/client-app-detail-manage/client-app-detail-manage.tsx
@@ -64,11 +64,13 @@ const ClientAppDetailManage: React.FC<ClientAppDetailManageProps> = () => {
         buttonGroup={renderAppHeaderButtonGroup(appDetailData.installedOn || '', onUninstallConfirmationModal)}
       />
       <AppContent appDetailData={appDetailData} loginType={loginType} />
-      <ClientAppUninstallConfirmation
-        visible={isVisibleUninstallConfirmation}
-        appDetailData={appDetailData}
-        closeUninstallConfirmationModal={closeUninstallConfirmationModal}
-      />
+      {isVisibleUninstallConfirmation && (
+        <ClientAppUninstallConfirmation
+          visible={isVisibleUninstallConfirmation}
+          appDetailData={appDetailData}
+          closeUninstallConfirmationModal={closeUninstallConfirmationModal}
+        />
+      )}
       {isLoadingAppDetail && <Loader />}
     </div>
   )