feat: #1125: Remove comments & update modal handler param names

reapit · May 11, 2020 · 59d2133 · 59d2133
1 parent e35560c
commit 59d2133
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/...es/marketplace/src/components/pages/client-app-detail-manage/client-app-detail-manage.tsx b/...es/marketplace/src/components/pages/client-app-detail-manage/client-app-detail-manage.tsx
@@ -12,14 +12,14 @@ import ClientAppUninstallConfirmation from '@/components/ui/client-app-detail/cl
 export type ClientAppDetailManageProps = {}
 
 export const handleCloseUninstallConfirmationModal = (
-  setIsVisibleUninstallConfirmation: (isModalOpen: boolean) => void,
+  setIsVisibleUninstallConfirmation: (isVisible: boolean) => void,
 ) => {
   return () => {
     setIsVisibleUninstallConfirmation(false)
   }
 }
 
-export const handleUninstallAppButtonClick = (setIsVisibleUninstallConfirmation: (isModalOpen: boolean) => void) => {
+export const handleUninstallAppButtonClick = (setIsVisibleUninstallConfirmation: (isVisible: boolean) => void) => {
   return () => {
     setIsVisibleUninstallConfirmation(true)
   }

diff --git a/packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx b/packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx
@@ -12,15 +12,13 @@ import ClientAppInstallConfirmation from '@/components/ui/client-app-detail/clie
 
 export type ClientAppDetailProps = {}
 
-export const handleCloseInstallConfirmationModal = (
-  setIsVisibleInstallConfirmation: (isModalOpen: boolean) => void,
-) => {
+export const handleCloseInstallConfirmationModal = (setIsVisibleInstallConfirmation: (isVisible: boolean) => void) => {
   return () => {
     setIsVisibleInstallConfirmation(false)
   }
 }
 
-export const handleInstallAppButtonClick = (setIsVisibleInstallConfirmation: (isModalOpen: boolean) => void) => {
+export const handleInstallAppButtonClick = (setIsVisibleInstallConfirmation: (isVisible: boolean) => void) => {
   return () => {
     setIsVisibleInstallConfirmation(true)
   }

diff --git a/packages/marketplace/src/components/ui/developer-app-detail/app-revision-comparision.tsx b/packages/marketplace/src/components/ui/developer-app-detail/app-revision-comparision.tsx
@@ -165,7 +165,6 @@ export const AppRevisionComparision: React.FC<AppRevisionComparisionProps> = ({
     return null
   }
   const { data: revision, scopes, desktopIntegrationTypes } = revisionDetailState.revisionDetailData
-  // const app = appDetailData
 
   return (
     <div>

diff --git a/.../marketplace/src/components/ui/developer-app-detail/developer-app-detail-button-group.tsx b/.../marketplace/src/components/ui/developer-app-detail/developer-app-detail-button-group.tsx
@@ -24,21 +24,21 @@ export const handleEditDetailButtonClick = (history, dispatch: Dispatch<any>, id
   }
 }
 
-export const handlenDeleteAppButtonClick = (setIsDeleteModalOpen: (isModalOpen: boolean) => void) => {
+export const handlenDeleteAppButtonClick = (setIsDeleteModalOpen: (isVisible: boolean) => void) => {
   return () => {
     setIsDeleteModalOpen(true)
   }
 }
 
 export const handlePendingRevisionButtonClick = (
-  setIsAppRevisionComparisionModalOpen: (isModalOpen: boolean) => void,
+  setIsAppRevisionComparisionModalOpen: (isVisible: boolean) => void,
 ) => {
   return () => {
     setIsAppRevisionComparisionModalOpen(true)
   }
 }
 
-export const handleInstallationButtonClick = (setIsInstallationsModalOpen: (isModalOpen: boolean) => void) => {
+export const handleInstallationButtonClick = (setIsInstallationsModalOpen: (isVisible: boolean) => void) => {
   return () => {
     setIsInstallationsModalOpen(true)
   }