Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build benchmarks in RMM CI #941

Merged
merged 6 commits into from
Jan 19, 2022
Merged

Build benchmarks in RMM CI #941

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b8af01
Add build.sh option to build benchmarks
harrism Jan 12, 2022
e1ad528
Build tests and benchmarks in CI for pull requests
harrism Jan 12, 2022
f0e31eb
Add params to docstring and move to ensureCMakeRan
harrism Jan 12, 2022
b1a29d8
Enable tests build for Project Flash
jjacobelli Jan 17, 2022
8001758
Add tests and benchmarks options to VALIDARGS
jjacobelli Jan 17, 2022
64ccbe4
Enable benchmarks build for Project Flash
jjacobelli Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ BUILD_DIRS="${LIBRMM_BUILD_DIR} ${RMM_BUILD_DIR}"
VERBOSE_FLAG=""
BUILD_TYPE=Release
INSTALL_TARGET=install
BUILD_BENCHMARKS=OFF
harrism marked this conversation as resolved.
Show resolved Hide resolved
BUILD_TESTS=OFF
CUDA_STATIC_RUNTIME=OFF
PER_THREAD_DEFAULT_STREAM=OFF
CUDA_MALLOC_ASYNC_SUPPORT=ON
Expand Down Expand Up @@ -125,6 +127,12 @@ fi
if hasArg -n; then
INSTALL_TARGET=""
fi
if hasArg benchmarks; then
BUILD_BENCHMARKS=ON
fi
if hasArg tests; then
BUILD_TESTS=ON
fi
if hasArg -s; then
CUDA_STATIC_RUNTIME=ON
fi
Expand Down Expand Up @@ -154,7 +162,9 @@ fi
if (( NUMARGS == 0 )) || hasArg librmm; then
ensureCMakeRan
echo "building librmm..."
cmake --build "${LIBRMM_BUILD_DIR}" -j${PARALLEL_LEVEL} ${VERBOSE_FLAG}
cmake --build "${LIBRMM_BUILD_DIR}" -j${PARALLEL_LEVEL} ${VERBOSE_FLAG} \
-DBUILD_TESTS=${BUILD_TESTS} \
-DBUILD_BENCHMARKS=${BUILD_BENCHMARKS}
harrism marked this conversation as resolved.
Show resolved Hide resolved
if [[ ${INSTALL_TARGET} != "" ]]; then
echo "installing librmm..."
cmake --build "${LIBRMM_BUILD_DIR}" --target install -v ${VERBOSE_FLAG}
Expand Down
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
################################################################################

gpuci_logger "Build and install librmm and rmm"
"$WORKSPACE/build.sh" -v clean librmm rmm
"$WORKSPACE/build.sh" -v clean librmm rmm benchmarks tests

################################################################################
# Test - librmm
Expand Down