Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build benchmarks in RMM CI #941

Merged
merged 6 commits into from
Jan 19, 2022
Merged

Build benchmarks in RMM CI #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b8af01
Add build.sh option to build benchmarks
harrism Jan 12, 2022
e1ad528
Build tests and benchmarks in CI for pull requests
harrism Jan 12, 2022
f0e31eb
Add params to docstring and move to ensureCMakeRan
harrism Jan 12, 2022
b1a29d8
Enable tests build for Project Flash
jjacobelli Jan 17, 2022
8001758
Add tests and benchmarks options to VALIDARGS
jjacobelli Jan 17, 2022
64ccbe4
Enable benchmarks build for Project Flash
jjacobelli Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,21 @@ ARGS=$*
# script, and that this script resides in the repo dir!
REPODIR=$(cd $(dirname $0); pwd)

VALIDARGS="clean librmm rmm -v -g -n -s --ptds --no-cudamallocasync -h"
VALIDARGS="clean librmm rmm -v -g -n -s --ptds --no-cudamallocasync -h tests benchmarks"
HELP="$0 [clean] [librmm] [rmm] [-v] [-g] [-n] [-s] [--ptds] [--no-cudamallocasync] [--cmake-args=\"<args>\"] [-h]
clean - remove all existing build artifacts and configuration (start over)
librmm - build and install the librmm C++ code
rmm - build and install the rmm Python package
-v - verbose build mode
-g - build for debug
-n - no install step
-s - statically link against cudart
--ptds - enable per-thread default stream
--no-cudamallocasync - disable CUDA malloc async support
--cmake-args=\\\"<args>\\\" - pass arbitrary list of CMake configuration options (escape all quotes in argument)
-h - print this text
clean - remove all existing build artifacts and configuration (start over)
librmm - build and install the librmm C++ code
rmm - build and install the rmm Python package
benchmarks - build benchmarks
tests - build tests
-v - verbose build mode
-g - build for debug
-n - no install step
-s - statically link against cudart
--ptds - enable per-thread default stream
--no-cudamallocasync - disable CUDA malloc async support
--cmake-args=\\\"<args>\\\" - pass arbitrary list of CMake configuration options (escape all quotes in argument)
-h - print this text

default action (no args) is to build and install 'librmm' and 'rmm' targets
"
Expand All @@ -42,6 +44,8 @@ BUILD_DIRS="${LIBRMM_BUILD_DIR} ${RMM_BUILD_DIR}"
VERBOSE_FLAG=""
BUILD_TYPE=Release
INSTALL_TARGET=install
BUILD_BENCHMARKS=OFF
harrism marked this conversation as resolved.
Show resolved Hide resolved
BUILD_TESTS=OFF
CUDA_STATIC_RUNTIME=OFF
PER_THREAD_DEFAULT_STREAM=OFF
CUDA_MALLOC_ASYNC_SUPPORT=ON
Expand Down Expand Up @@ -92,6 +96,8 @@ function ensureCMakeRan {
-DPER_THREAD_DEFAULT_STREAM="${PER_THREAD_DEFAULT_STREAM}" \
-DCUDA_MALLOC_ASYNC_SUPPORT="${CUDA_MALLOC_ASYNC_SUPPORT}" \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
-DBUILD_TESTS=${BUILD_TESTS} \
-DBUILD_BENCHMARKS=${BUILD_BENCHMARKS} \
${CMAKE_ARGS}
RAN_CMAKE=1
fi
Expand Down Expand Up @@ -125,6 +131,12 @@ fi
if hasArg -n; then
INSTALL_TARGET=""
fi
if hasArg benchmarks; then
BUILD_BENCHMARKS=ON
fi
if hasArg tests; then
BUILD_TESTS=ON
fi
if hasArg -s; then
CUDA_STATIC_RUNTIME=ON
fi
Expand Down
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
################################################################################

gpuci_logger "Build and install librmm and rmm"
"$WORKSPACE/build.sh" -v clean librmm rmm
"$WORKSPACE/build.sh" -v clean librmm rmm benchmarks tests

################################################################################
# Test - librmm
Expand Down
6 changes: 5 additions & 1 deletion conda/recipes/librmm/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Copyright (c) 2018-2019, NVIDIA CORPORATION.

# This assumes the script is executed from the root of the repo directory
./build.sh -v clean librmm --cmake-args=\"-DCMAKE_INSTALL_LIBDIR=lib\"
if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
./build.sh -v clean librmm --cmake-args=\"-DCMAKE_INSTALL_LIBDIR=lib\"
else
./build.sh -v clean librmm tests benchmarks --cmake-args=\"-DCMAKE_INSTALL_LIBDIR=lib\"
fi
1 change: 1 addition & 0 deletions conda/recipes/librmm/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ build:
- CMAKE_C_COMPILER_LAUNCHER
- CMAKE_CXX_COMPILER_LAUNCHER
- CMAKE_CUDA_COMPILER_LAUNCHER
- PROJECT_FLASH
run_exports:
- {{ pin_subpackage("librmm", max_pin="x.x") }}

Expand Down