Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build benchmarks in RMM CI #941

Merged
merged 6 commits into from
Jan 19, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 12, 2022

Fixes #940

Adds options to build tests and benchmarks to build.sh, and uses them in ci/gpu/build.sh

@harrism harrism requested a review from a team as a code owner January 12, 2022 05:01
@github-actions github-actions bot added the gpuCI label Jan 12, 2022
@harrism harrism self-assigned this Jan 12, 2022
@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Jan 12, 2022
build.sh Outdated Show resolved Hide resolved
@jjacobelli
Copy link
Contributor

Following what is done in other repos, you might need to update the conda build scripts to also build tests if Project Flash is enabled. See https://github.com/rapidsai/cudf/blob/branch-22.02/conda/recipes/libcudf/build.sh as example

@harrism
Copy link
Member Author

harrism commented Jan 14, 2022

@Ethyling that seems out of scope for this PR. This PR is about building benchmarks, not tests. Also I'm out sick and we are in burndown. so could you approve the present PR and just file an issue for this detail?

@jjacobelli
Copy link
Contributor

@Ethyling that seems out of scope for this PR. This PR is about building benchmarks, not tests. Also I'm out sick and we are in burndown. so could you approve the present PR and just file an issue for this detail?

I think this is required to fix this CI issue: ci/gpu/build.sh: line 106: build/gtests/*: No such file or directory

Before this PR, the default value of BUILD_TESTS in CMake was ON, see: https://github.com/rapidsai/rmm/blob/branch-22.02/CMakeLists.txt#L38
Now it's OFF due to these changes:

This change only applies for non Project Flash builds: https://github.com/rapidsai/rmm/pull/941/files#diff-285f239638b8b5c5499ef5fda2e3db69adda7045e81556b4f2df478e99ab6263R71

But rmm is using Project Flash builds, so we also need to enable tests build for it.
As we are using the conda artifacts to run the tests in a Project Flash build, we need to add the test target when we are doing the conda build.

@harrism WDYT?

@harrism
Copy link
Member Author

harrism commented Jan 15, 2022

Ah, I see now. Unfortunately I'm out sick so will have to wait until next week unless you want to commit a fix.

@github-actions github-actions bot added the conda label Jan 17, 2022
@jjacobelli
Copy link
Contributor

@harrism The tests and benchmarks are now building on PRs, but we only run the tests currently. Should we also run the benchmarks?

@harrism
Copy link
Member Author

harrism commented Jan 18, 2022

No, don't run the benchmarks. Benchmarking is a separate effort and would likely not be done on every PR. We just need to make sure PRs don't break the benchmark build.

@harrism
Copy link
Member Author

harrism commented Jan 18, 2022

Thanks for the help, @Ethyling !

@harrism
Copy link
Member Author

harrism commented Jan 19, 2022

Is this ready to merge now? Still needs ops approval.

@jakirkham jakirkham requested a review from jjacobelli January 19, 2022 03:56
@jjacobelli
Copy link
Contributor

Is this ready to merge now? Still needs ops approval.

We are good to merge

@harrism
Copy link
Member Author

harrism commented Jan 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 11f1599 into rapidsai:branch-22.02 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda gpuCI non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Benchmarks are not being built in CI
3 participants