Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rmm::mr::device_memory_resource::get_mem_info() and supports_get_mem_info(). #1436

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 24, 2024

Description

Closes #1427 . Part of #1388.

#1430 made these functions non-virtual and removed them from all MRs and tests. This PR completes the next step of deprecating them.

Merge after

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested review from a team as code owners January 24, 2024 01:14
@harrism harrism requested review from cwharris and vyasr January 24, 2024 01:14
@harrism harrism self-assigned this Jan 24, 2024
@github-actions github-actions bot added CMake Python Related to RMM Python API cpp Pertains to C++ code ci labels Jan 24, 2024
@harrism harrism added feature request New feature or request breaking Breaking change and removed CMake Python Related to RMM Python API cpp Pertains to C++ code ci labels Jan 24, 2024
@harrism harrism changed the base branch from branch-24.02 to branch-24.04 January 24, 2024 02:10
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark!

@bdice bdice removed the request for review from a team January 26, 2024 15:43
@miscco
Copy link
Contributor

miscco commented Jan 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit e374a27 into rapidsai:branch-24.04 Jan 26, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
Status: Done
4 participants