Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info(). #1427

Closed
Tracked by #1388
harrism opened this issue Jan 18, 2024 · 1 comment · Fixed by #1436
Closed
Tracked by #1388

Deprecate rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info(). #1427

harrism opened this issue Jan 18, 2024 · 1 comment · Fixed by #1436
Assignees
@harrism
Labels
cpp Pertains to C++ code feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Jan 18, 2024 •
edited
Loading

Part of #1388. Do after #1426 .
@harrism harrism mentioned this issue Jan 18, 2024
Closed
@harrism harrism added feature request New feature or request cpp Pertains to C++ code labels Jan 18, 2024
@harrism harrism mentioned this issue Jan 18, 2024
Closed
@harrism harrism changed the title Deprecate rmm::mr::device_memory_resource_get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info(). Deprecate rmm::mr::device_memory_resource::get_mem_info() and rmm::mr::device_memory_resource::supports_get_mem_info(). Jan 22, 2024
@harrism harrism mentioned this issue Jan 24, 2024
Merged
3 tasks
@harrism harrism moved this from Todo to Review in RMM Project Board Jan 24, 2024
@harrism harrism self-assigned this Jan 24, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 26, 2024
@harrism
Deprecate rmm::mr::device_memory_resource::get_mem_info() and support…
e374a27 
…s_get_mem_info(). (#1436)

Closes #1427 . Part of #1388.

#1430 made these functions non-virtual and removed them from all MRs and tests. This PR completes the next step of deprecating them.  

Merge after 
 - rapidsai/raft#2108
 - rapidsai/cudf#14832

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Bradley Dice (https://github.com/bdice)

URL: #1436
@harrism
Copy link
Member Author

harrism commented Jan 30, 2024

Fixed by #1436

@harrism harrism closed this as completed Jan 30, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
cpp Pertains to C++ code feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate rmm::mr::device_memory_resource::get_mem_info() and supports_get_mem_info(). harrism/rmm
1 participant
@harrism