Remove get_mem_info functions from custom memory resources #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
harrism
changed the title
jlowe
approved these changes
Jan 23, 2024
ttnghia
approved these changes
Jan 23, 2024
vyasr
added
improvement
vuule
approved these changes
Jan 23, 2024
vyasr
added
non-breaking
|
/merge |
3 tasks
PointKernel
pushed a commit
to PointKernel/cudf
that referenced
this pull request
Jan 25, 2024
…14832) Part of rapidsai/rmm#1388. This removes now-optional and soon-to-be deprecated functions from cuDF's custom device_memory_resource implementations: * `supports_get_mem_info()` * `do_get_mem_info()` Authors: - Mark Harris (https://github.com/harrism) Approvers: - Jason Lowe (https://github.com/jlowe) - Nghia Truong (https://github.com/ttnghia) - Vukasin Milovanovic (https://github.com/vuule) URL: rapidsai#14832
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jan 26, 2024
…s_get_mem_info(). (#1436) Closes #1427 . Part of #1388. #1430 made these functions non-virtual and removed them from all MRs and tests. This PR completes the next step of deprecating them. Merge after - rapidsai/raft#2108 - rapidsai/cudf#14832 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Michael Schellenberger Costa (https://github.com/miscco) - Bradley Dice (https://github.com/bdice) URL: #1436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of rapidsai/rmm#1388. This removes now-optional and soon-to-be deprecated functions from cuDF's custom device_memory_resource implementations:
supports_get_mem_info()do_get_mem_info()Checklist