Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nvbench initializes nvml context when built statically #486

Conversation

robertmaynard
Copy link
Contributor

Description

Provide NVIDIA/nvbench#148 as a patch to the nvbench that rapids-cmake provides

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Nov 14, 2023
@robertmaynard
Copy link
Contributor Author

Being tested by: rapidsai/cudf#14411

@robertmaynard robertmaynard requested a review from bdice November 14, 2023 19:56
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6f1ce07 into rapidsai:branch-23.12 Nov 14, 2023
14 checks passed
@robertmaynard robertmaynard deleted the bug/support_nvml_when__nvbench_is_built_statically branch November 14, 2023 21:06
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Approved offline)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants