Support static builds of nvbench with nvml enabled. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this we need to ensure that the nvml init handler is both contained in the library/executable that uses nvbench. The original implementation fails since the singleton can be dropped since it has no usages. So instead we move to a function static which we ensure will always be used.
robertmaynard
added
type: bug: functional
bdice
approved these changes
Nov 14, 2023
Co-authored-by: Bradley Dice <[email protected]>
This was referenced Nov 14, 2023
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Nov 14, 2023
Provide NVIDIA/nvbench#148 as a patch to the nvbench that rapids-cmake provides Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: None URL: #486
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 14, 2023
Port NVIDIA/nvbench#148 to cudf so that nvbench benchmarks work now that we always use a static version of nvbench. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) URL: #14411
4 tasks
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Nov 20, 2023
With NVIDIA/nvbench#148 being merged we can drop our custom patch for nvbench and use latest upstream. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) URL: #488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this we need to ensure that the nvml init handler is both contained in the library/executable that uses nvbench.
The original implementation fails since the singleton can be dropped since it has no usages. So instead we move to a function static which we ensure will always be used.