Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nvbench initializes nvml context when built statically #14411

Conversation

robertmaynard
Copy link
Contributor

Description

Port NVIDIA/nvbench#148 to cudf so that nvbench benchmarks work now that we always use a static version of nvbench.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard marked this pull request as draft November 14, 2023 19:31
@robertmaynard robertmaynard requested a review from a team as a code owner November 14, 2023 19:34
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 14, 2023
@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change labels Nov 14, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard Do you know why this nvbench we run in our CI tests doesn't seem to catch the problem?

cudf/ci/test_cpp.sh

Lines 37 to 41 in b446a6f

if (( ${SUITEERROR} == 0 )); then
# Run a small nvbench benchmark
./STRINGS_NVBENCH --run-once --benchmark 0 --devices 0
SUITEERROR=$?
fi

@robertmaynard
Copy link
Contributor Author

@robertmaynard Do you know why this nvbench we run in our CI tests doesn't seem to catch the problem?

cudf/ci/test_cpp.sh

Lines 37 to 41 in b446a6f

if (( ${SUITEERROR} == 0 )); then
# Run a small nvbench benchmark
./STRINGS_NVBENCH --run-once --benchmark 0 --devices 0
SUITEERROR=$?
fi

I presume that our CI build env doesn't have nvml, so therefore nvbench doesn't enable the feature and we avoid the issue.

@robertmaynard robertmaynard force-pushed the bug/ensure_nvbench_is_built_statically branch from 328a18c to a5db97f Compare November 14, 2023 21:08
@robertmaynard robertmaynard marked this pull request as ready for review November 14, 2023 21:08
@robertmaynard robertmaynard requested a review from bdice November 14, 2023 21:08
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 330d389 into rapidsai:branch-23.12 Nov 14, 2023
63 checks passed
@robertmaynard robertmaynard deleted the bug/ensure_nvbench_is_built_statically branch November 15, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants