Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix row/col-major selection for strided layouts #2166

Closed
wants to merge 2 commits into from
Closed

[BUG] fix row/col-major selection for strided layouts #2166

wants to merge 2 commits into from

Conversation

mfoerste4
Copy link
Collaborator

This PR fixes the SPARSE_DIST_TEST after a combination of changes introduced by #2067, #2117, and #2124.

Scope:

  • layout_stride does not check for contiguous data when asked for row/col-major
  • make_device_strided_matrix_view does assert when called with neither layout_c_contiguous or layout_f_contiguous
  • usage adjusted accordingly in spmm

CC @cjnolet @lowener

@trxcllnt - please verify that the initial cusparse-alignment bug is still fixed after #2124

@mfoerste4 mfoerste4 requested a review from a team as a code owner February 7, 2024 16:32
@github-actions github-actions bot added the cpp label Feb 7, 2024
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Feb 7, 2024
cjnolet
cjnolet approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mfoerste4!

@cjnolet
Copy link
Member

cjnolet commented Feb 7, 2024

Changes merged into #2167. Closing for now to save CI resources.

@cjnolet cjnolet closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowener lowener lowener approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfoerste4 @cjnolet @lowener