Fixing small bug in CUSPARSE spmm w/ CUDA 12.2 #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
approved these changes
Jan 24, 2024
|
/merge |
trxcllnt
reviewed
Jan 24, 2024
| auto z_tmp = raft::make_device_matrix<ValueType, IndexType>(handle, z.extent(0), z.extent(1)); | ||
| auto z_tmp_view = raft::make_device_strided_matrix_view<ValueType, IndexType, LayoutPolicyZ>( | ||
| z_tmp.data_handle(), z.extent(0), z.extent(1), is_row_major ? z.stride(0) : z.stride(1)); | ||
|
|
There was a problem hiding this comment.
I think we also need to copy z into z_tmp, since it's an in/out buffer in cuSparse?
Suggested change
| raft::copy( | |
| z_tmp_view.data_handle(), z.data_handle(), z.size(), raft::resource::get_cuda_stream(handle)); | |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
With the bug fix #2117 there can be an issue with `z_tmp` memory being uninitialized. SPMM formula is `Z = alpha . X * Y + beta . Z` so when `beta` is not zero, Z is being read. The proposed solution in this PR remove the need for an extra allocation and a copy from/to an external buffer, by creating a strided view of the original Z. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #2124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.