Fix CAGRA filter gtests #2167
Closed
Fix CAGRA filter gtests #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit rapidsai@fea490a attempted to fix a problem where the search_params.itopk_size wasn't being set in the CAGRA filter tests. This change was required to enable testing k>1024, since the default itopk_size was too small. However, this broke the unittest for k < 1024 - and was causing illegal memory access errors. Fix by reverting the filter tests to the previous behaviour, and disabling the filter tests for k>1024
achirkin
reviewed
Feb 8, 2024
achirkin
reviewed
Feb 8, 2024
achirkin
reviewed
Feb 8, 2024
Co-authored-by: Artem M. Chirkin <[email protected]>
Fix incorrect shared memory size in ivf_flat_interleaved_scan
|
Closing in favour of #2181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fea490a attempted to fix a problem where the search_params.itopk_size wasn't being set in the CAGRA filter tests.
This change was required to enable testing k>1024, since the default itopk_size was too small. However, this broke the unittest for k < 1024 - and was causing illegal memory access errors.
Fix by reverting the filter tests to the previous behaviour, and disabling the filter tests for k>1024