Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipes to GTest version >=1.13.0 #1501

Merged
merged 4 commits into from
May 10, 2023
Merged

Update recipes to GTest version >=1.13.0 #1501

merged 4 commits into from
May 10, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 9, 2023

This PR updates GTest pinnings to >=1.13.0. This aligns with recent changes in rapids-cmake: rapidsai/rapids-cmake#401.

@bdice bdice mentioned this pull request May 9, 2023
Merged
@bdice bdice marked this pull request as ready for review May 9, 2023 18:13
@bdice bdice requested a review from a team as a code owner May 9, 2023 18:13
@divyegala divyegala requested a review from a team as a code owner May 9, 2023 21:51
@github-actions github-actions bot added the cpp label May 9, 2023
bdice
bdice commented May 9, 2023
View reviewed changes
Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the .* to align with changes being made elsewhere (including in cudf where this was likely copied from).

dependencies.yaml Outdated Show resolved Hide resolved
@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@bdice
Copy link
Contributor Author

bdice commented May 9, 2023

I think CI failed due to a flaky test. I lack write permissions on this repo to rerun that single job, so I am merging the upstream to rerun CI.

>       assert index.size >= n_rows
E       assert 9969 >= 10000
E        +  where 9969 = Index(type=IVF-FLAT, metric=sqeuclidean, size=9969, dim=10, n_lists=100, adaptive_centers=False).size

python/pylibraft/pylibraft/test/test_ivf_flat.py:132: AssertionError
=========================== short test summary info ============================
FAILED python/pylibraft/pylibraft/test/test_ivf_flat.py::test_extend[device-int8] - assert 9969 >= 10000
 +  where 9969 = Index(type=IVF-FLAT, metric=sqeuclidean, size=9969, dim=10, n_lists=100, adaptive_centers=False).size
======= 1 failed, 1471 passed, 24 skipped, 4 xfailed in 62.83s (0:01:02) =======

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f60fb79 into rapidsai:branch-23.06 May 10, 2023
@bdice
Copy link
Contributor Author

bdice commented May 10, 2023

@divyegala You're the best! Thank you so much for your help on this. You're a force multiplier! 💪

rapids-bot bot pushed a commit to rapidsai/integration that referenced this pull request May 10, 2023
@bdice
Update recipes to GTest version >=1.13.0 (#646)
0cfda78 
This PR updates GTest pinnings to >=1.13.0. This aligns with recent changes in rapids-cmake: rapidsai/rapids-cmake#401.

This PR should probably wait on the following to merge:
- rapidsai/cuml#5408
- rapidsai/raft#1501
- rapidsai/rmm#1263
- rapidsai/cudf#13319
- rapidsai/cugraph#3549

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @divyegala @cjnolet @raydouglass