Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gtest pinning to 1.13.0. #13319

Merged
merged 3 commits into from
May 9, 2023
Merged

Fix gtest pinning to 1.13.0. #13319

merged 3 commits into from
May 9, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 9, 2023

Description

Fixes gtest pinning. The .* is not needed here. This aligns with similar changes I'm making in other RAPIDS repos to bump their gtest pinnings.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner May 9, 2023 16:03
@github-actions github-actions bot added the conda label May 9, 2023
@bdice bdice mentioned this pull request May 9, 2023
Merged
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@bdice
Copy link
Contributor Author

bdice commented May 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit a1c2eec into rapidsai:branch-23.06 May 9, 2023
rapids-bot bot pushed a commit to rapidsai/integration that referenced this pull request May 10, 2023
@bdice
Update recipes to GTest version >=1.13.0 (#646)
0cfda78 
This PR updates GTest pinnings to >=1.13.0. This aligns with recent changes in rapids-cmake: rapidsai/rapids-cmake#401.

This PR should probably wait on the following to merge:
- rapidsai/cuml#5408
- rapidsai/raft#1501
- rapidsai/rmm#1263
- rapidsai/cudf#13319
- rapidsai/cugraph#3549

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @raydouglass