Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipes to GTest version >=1.13.0 #5408

Merged
merged 6 commits into from
May 10, 2023
Merged

Update recipes to GTest version >=1.13.0 #5408

merged 6 commits into from
May 10, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 9, 2023

This PR updates GTest pinnings to >=1.13.0. This aligns with recent changes in rapids-cmake: rapidsai/rapids-cmake#401.

@github-actions github-actions bot added the conda conda issue label May 9, 2023
@bdice bdice mentioned this pull request May 9, 2023
Merged
@bdice bdice marked this pull request as ready for review May 9, 2023 18:13
@bdice bdice requested a review from a team as a code owner May 9, 2023 18:13
@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@bdice
Copy link
Contributor Author

bdice commented May 9, 2023 •
edited
Loading

I think CI failed due to a flaky test?

[----------] 4 tests from RfTests/MSEObjectiveTestD
[ RUN      ] RfTests/MSEObjectiveTestD.MSEObjectiveTest/0
/opt/conda/conda-bld/work/cpp/test/sg/rf_test.cu:1193: Failure
The difference between ground_truth_gain and hypothesis_gain is nan, which exceeds params.tolerance, where
ground_truth_gain evaluates to -nan,
hypothesis_gain evaluates to -nan, and
params.tolerance evaluates to 1.0000000000000001e-05.
[  FAILED  ] RfTests/MSEObjectiveTestD.MSEObjectiveTest/0, where GetParam() = 32-byte object <DF-BF C0-70 97-8F F2-83 00-08 00-00 40-00 00-00 01-00 00-00 00-00 00-00 F1-68 E3-88 B5-F8 E4-3E> (0 ms)

I lack write permissions on this repo so I merged the upstream to trigger a rerun.

@dantegd
Copy link
Member

dantegd commented May 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 403acc5 into rapidsai:branch-23.06 May 10, 2023
rapids-bot bot pushed a commit to rapidsai/integration that referenced this pull request May 10, 2023
@bdice
Update recipes to GTest version >=1.13.0 (#646)
0cfda78 
This PR updates GTest pinnings to >=1.13.0. This aligns with recent changes in rapids-cmake: rapidsai/rapids-cmake#401.

This PR should probably wait on the following to merge:
- rapidsai/cuml#5408
- rapidsai/raft#1501
- rapidsai/rmm#1263
- rapidsai/cudf#13319
- rapidsai/cugraph#3549

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @dantegd @raydouglass @divyegala