Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add gather & gatherv to raft::comms::comms_t #114

Merged
merged 6 commits into from
Feb 3, 2021
Merged

[REVIEW] Add gather & gatherv to raft::comms::comms_t #114

merged 6 commits into from
Feb 3, 2021

Conversation

seunghwak
Copy link
Contributor

  • Add gather & gatherv to raft::comms::comms_t, raft::comms::std_comms_t, and raft::comms::mpi_comms_t

@seunghwak seunghwak changed the title Add gather & gatherv to raft::comms::comms_t [REVIEW] Add gather & gatherv to raft::comms::comms_t Dec 10, 2020
@seunghwak
Copy link
Contributor Author

This addresses #114

cjnolet
cjnolet requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition LGTM. Can you also expose a small test through test.hpp? Ideally we would also expose it to the Python layer for sanity checks.

@seunghwak
Copy link
Contributor Author

The addition LGTM. Can you also expose a small test through test.hpp? Ideally we would also expose it to the Python layer for sanity checks.

Sure, I will. I will test this locally with cuGraph first, and then, I will add a test suite.

@dantegd dantegd added the 4 - Waiting on Author Waiting for author to respond to review label Dec 14, 2020
@seunghwak seunghwak requested a review from cjnolet January 27, 2021 14:25
@dantegd dantegd added enhancement New feature or request non-breaking Non-breaking change labels Feb 3, 2021
@afender afender added 3 - Ready for Review improvement Improvement / enhancement to an existing function and removed 4 - Waiting on Author Waiting for author to respond to review labels Feb 3, 2021
afender
afender approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

cjnolet
cjnolet approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@cjnolet cjnolet merged commit 4a79adc into rapidsai:branch-0.18 Feb 3, 2021
@seunghwak seunghwak mentioned this pull request Feb 9, 2021
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 25, 2021
@seunghwak
Matching updates for RAFT comms updates (device_sendrecv, device_mult…
06ac713 
…icast_sendrecv, gather, gatherv) (#1391)

- [x] Update cuGraph to use RAFT::comms_t's newly added device_sendrecv & device_multicast_sendrecv)
- [x] Update cuGraph to use RAFT::comms_t's newly added gather & gatherv
- [x] Update RAFT git tag once rapidsai/raft#114 (currently merged in 0.18 but is not merged to 0.19) and rapidsai/raft#144 are merged to 0.19

Ready for review but cannot be merged till RAFT PR 114 and 144 are merged to RAFT branch-0.19.

Authors:
  - Seunghwa Kang (@seunghwak)

Approvers:
  - Alex Fender (@afender)

URL: #1391
@seunghwak seunghwak mentioned this pull request May 17, 2021
Closed
dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
@trxcllnt
hide RAFT #pragma deprecation warnings (rapidsai#114)
ac85fa6 
Define `-DRAFT_HIDE_DEPRECATION_WARNINGS` added in rapidsai#2271.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review enhancement New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @cjnolet @afender @dantegd