Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide RAFT #pragma deprecation warnings #114

Merged
merged 8 commits into from
May 23, 2024
Merged

hide RAFT #pragma deprecation warnings #114

merged 8 commits into from
May 23, 2024

Conversation

trxcllnt
Copy link
Contributor

Define -DRAFT_HIDE_DEPRECATION_WARNINGS added in rapidsai/raft#2271.

@trxcllnt trxcllnt requested a review from a team as a code owner May 10, 2024 19:15
@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 10, 2024
@trxcllnt
Copy link
Contributor Author

Seems like raft headers have code that triggers warnings. Since the pip builds add raft as a CMake submodule, the raft includes are added as -I instead of -isystem, so raft warnings are failing the -Werror cuvs build.

Doesn't raft build with -Werror? It seems like any raft warnings should have been caught in the raft CI before being merged?

@trxcllnt trxcllnt requested a review from a team as a code owner May 13, 2024 19:17
@cjnolet
Copy link
Member

cjnolet commented May 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit ac85fa6 into branch-24.06 May 23, 2024
55 checks passed
@trxcllnt trxcllnt deleted the fix/hide-raft-deprecation-warnings branch May 23, 2024 18:11
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this pull request Aug 10, 2024
@difyrrwrzd
hide RAFT #pragma deprecation warnings (#114)
00755e7 
Define `-DRAFT_HIDE_DEPRECATION_WARNINGS` added in rapidsai/raft#2271.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @cjnolet