Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builds for CUDA 11.8 and Python 3.10 #1120

Merged
merged 14 commits into from
Jan 17, 2023
Merged

Update builds for CUDA 11.8 and Python 3.10 #1120

merged 14 commits into from
Jan 17, 2023

Conversation

ajschmidt8
Copy link
Member

This PR updates the raft CI workflows to build against the CUDA 11.8 / Python 3.10 branch of the shared-action-workflows repository.

@ajschmidt8
Update builds for CUDA 11.8 and Python 3.10
acd8fb0 
This PR updates the `raft` CI workflows to build against the CUDA `11.8` / Python `3.10` [branch](https://github.com/rapidsai/shared-action-workflows/tree/cuda-118) of the `shared-action-workflows` repository.
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 4, 2023
@bdice
Copy link
Contributor

bdice commented Jan 5, 2023 •
edited
Loading

This PR is blocked until we can get ARM + CUDA builds of faiss version 1.7.1 or newer (see ongoing work here: conda-forge/faiss-split-feedstock#58) or remove the faiss dependency entirely (several open issues, including #798, #799, #803, ...).

The existing ARM + CUDA builds of faiss 1.7.0 do not support GPU architectures newer than 80, which we need to support (86 and 90).

@jakirkham
Copy link
Member

jakirkham commented Jan 7, 2023 •
edited
Loading

PR ( conda-forge/faiss-split-feedstock#58 ) added ARM builds (without CUDA). So just CPU builds. That said, this does seem to cover the changes we had in other places before. Though please double check that.

PR ( conda-forge/faiss-split-feedstock#62 ) adds CUDA builds. Based on Bradley's comment above, think we should check that the recipe is doing what we want with CUDA arches. There is a second point about build time, which I've outlined in more detail in comment ( conda-forge/faiss-split-feedstock#62 (comment) ). Feel free to raise anything else I've missed in that PR.

Edit: Also commented on CUDA arches here ( conda-forge/faiss-split-feedstock#62 (comment) )

This was referenced Jan 7, 2023
Merged
Merged
@ajschmidt8 ajschmidt8 mentioned this pull request Jan 13, 2023
Merged
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this pull request Jan 13, 2023
@ajschmidt8
Build CUDA 11.8 and Python 3.10 Packages (#916)
52e9c32 
This PR updates `ucx-py` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA `11.8` and Python `3.10` packages.

It also includes some minor file renames.


This PR will unblock the following PRs:

- rapidsai/raft#1120
- rapidsai/dask-cuda#1080

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #916
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023 •
edited
Loading

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (3100871) compared to base (2af2749).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-23.02    #1120   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 marked this pull request as ready for review January 14, 2023 04:46
@ajschmidt8 ajschmidt8 requested review from a team as code owners January 14, 2023 04:46
@ajschmidt8 ajschmidt8 requested a review from cjnolet January 16, 2023 13:17
cjnolet
cjnolet approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for also updating the build docs!

@ajschmidt8
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 9a97b52 into rapidsai:branch-23.02 Jan 17, 2023
@ajschmidt8 ajschmidt8 deleted the cuda-118 branch January 17, 2023 20:59
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Jan 24, 2023
@bdice
Build CUDA 11.8 and Python 3.10 Packages (#3120)
014faf2 
This PR updates `cugraph` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

Authors:
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3120
@bdice bdice mentioned this pull request Jan 24, 2023
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 30, 2023
@bdice
Build CUDA 11.8 and Python 3.10 Packages (#5120)
5dacb91 
This PR updates `cuml` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - William Hicks (https://github.com/wphicks)
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #5120
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@bdice
Build CUDA 11.8 and Python 3.10 Packages (rapidsai#5120)
7992930 
This PR updates `cuml` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - William Hicks (https://github.com/wphicks)
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#5120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@cjnolet cjnolet

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ajschmidt8 @bdice @jakirkham @codecov-commenter @cjnolet @raydouglass @AyodeAwe