Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests run for Python 3.10 #1080

Merged
merged 7 commits into from
Jan 18, 2023

Conversation

ajschmidt8
Copy link
Member

Previously we had disabled cucim testing for Python 3.10 because the tests depended on 3.10 packages of cudf, which weren't previously available.

Now that 3.10 packages of cudf are available, we can enable 3.10 testing for cucim.

Previously we had disabled `cucim` testing for Python `3.10` because the tests depended on `3.10` packages of `cudf`, which weren't previously available.

Now that `3.10` packages of `cudf` are available, we can enable `3.10` testing for `cucim`.
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2023
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner January 11, 2023 14:49
@ajschmidt8
Copy link
Member Author

/merge

@charlesbluca
Copy link
Member

charlesbluca commented Jan 11, 2023

It looks like this is failing because there aren't 3.10 builds of cucim available yet:

Encountered problems while solving:
  - package cucim-23.02.00a221226-cuda_11_py39_gc06355c_37 requires python_abi 3.9.* *_cp39, but none of the providers can be installed 

@ajschmidt8
Copy link
Member Author

It looks like this is failing because there aren't 3.10 builds of cucim available yet:

I will open that PR now.

@ajschmidt8
Copy link
Member Author

rapidsai/cucim#476

rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this pull request Jan 13, 2023
This PR updates `ucx-py` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA `11.8` and Python `3.10` packages.

It also includes some minor file renames.


This PR will unblock the following PRs:

- rapidsai/raft#1120
- rapidsai/dask-cuda#1080

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #916
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 87.04% // Head: 87.04% // No change to project coverage 👍

Coverage data is based on head (68503a8) compared to base (52dd850).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #1080   +/-   ##
=============================================
  Coverage         87.04%   87.04%           
=============================================
  Files                18       18           
  Lines              2300     2300           
=============================================
  Hits               2002     2002           
  Misses              298      298           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8
Copy link
Member Author

This PR needs rapidsai/cucim#480 published before it will pass.

@github-actions github-actions bot added the gpuCI gpuCI issue label Jan 18, 2023
@ajschmidt8
Copy link
Member Author

this PR needs #1086 to fix the current CI failures.

@rapids-bot rapids-bot bot merged commit 2c88933 into rapidsai:branch-23.02 Jan 18, 2023
@ajschmidt8 ajschmidt8 deleted the update-tests branch January 18, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants