Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CUDA 11.8 and Python 3.10 Packages #5120

Merged
merged 38 commits into from
Jan 30, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 7, 2023

This PR updates cuml to build against branch cuda-118 of the shared-action-workflow repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Jan 7, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 18, 2023
ajschmidt8 and others added 22 commits January 18, 2023 11:43
this commit updates the `faiss` version to be compatible with CUDA `11.8` builds
this commit reverts the previous changes since they will be addressed in a separate PR
…` will have to be explicitly included. This is also going to be important for the future changes to RAFT as eventually each header will only be including the resources it needs.
…ition' into bug-2302-remove_raft_abs_redefinition
@codecov-commenter
Copy link

Codecov Report

Base: 69.26% // Head: 68.76% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (1b67bf6) compared to base (de32125).
Patch coverage: 91.11% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5120      +/-   ##
================================================
- Coverage         69.26%   68.76%   -0.51%     
================================================
  Files               192      192              
  Lines             12333    12396      +63     
================================================
- Hits               8543     8524      -19     
- Misses             3790     3872      +82     
Impacted Files Coverage Δ
python/cuml/testing/strategies.py 92.85% <90.47%> (-1.22%) ⬇️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 91.11% <100.00%> (+0.20%) ⬆️
python/cuml/neighbors/kernel_density.py 70.12% <0.00%> (-17.54%) ⬇️
python/cuml/feature_extraction/_vectorizers.py 84.38% <0.00%> (-5.65%) ⬇️
python/cuml/common/kernel_utils.py 91.66% <0.00%> (-4.17%) ⬇️
python/cuml/dask/neighbors/kneighbors_regressor.py 30.64% <0.00%> (-2.12%) ⬇️
python/cuml/dask/neighbors/nearest_neighbors.py 26.74% <0.00%> (-2.01%) ⬇️
...party/sklearn/preprocessing/_column_transformer.py 72.99% <0.00%> (-1.95%) ⬇️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 21.84% <0.00%> (-1.58%) ⬇️
python/cuml/internals/array.py 87.35% <0.00%> (-0.80%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 marked this pull request as ready for review January 30, 2023 22:30
@ajschmidt8 ajschmidt8 requested review from a team as code owners January 30, 2023 22:30
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a question

Comment on lines +95 to +96
FORK cjnolet
PINNED_TAG imp-2302-raft_device_resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dantegd, @cjnolet, should we merge the PR with this change and revert it in a follow-up?

Or should we remove it first?

FWIW, this PR is holding up a few things, so if we can revert it in a follow-up, I'd vote for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revert it in a follow up, but will wait on @cjnolet input

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can open another PR in a follow-up, that way we can unblock other things in the meantime.

@cjnolet
Copy link
Member

cjnolet commented Jan 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5dacb91 into rapidsai:branch-23.02 Jan 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Feb 1, 2023

Thanks to all the folks who chipped in on this PR -- much appreciated!

jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR updates `cuml` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - William Hicks (https://github.com/wphicks)
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#5120
@bdice bdice deleted the cuda-118 branch May 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants