-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CUDA 11.8 and Python 3.10 Packages #5120
Conversation
this commit updates the `faiss` version to be compatible with CUDA `11.8` builds
this commit reverts the previous changes since they will be addressed in a separate PR
… accepting device_resources everywhere
…` will have to be explicitly included. This is also going to be important for the future changes to RAFT as eventually each header will only be including the resources it needs.
…emove_raft_abs_redefinition
…ition' into bug-2302-remove_raft_abs_redefinition
…device_resources_changes
…evice_resources_changes
…evice_resources_changes
Codecov ReportBase: 69.26% // Head: 68.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5120 +/- ##
================================================
- Coverage 69.26% 68.76% -0.51%
================================================
Files 192 192
Lines 12333 12396 +63
================================================
- Hits 8543 8524 -19
- Misses 3790 3872 +82
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a question
FORK cjnolet | ||
PINNED_TAG imp-2302-raft_device_resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can revert it in a follow up, but will wait on @cjnolet input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can open another PR in a follow-up, that way we can unblock other things in the meantime.
/merge |
Thanks to all the folks who chipped in on this PR -- much appreciated! |
This PR updates `cuml` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository. That branch contains updates for CUDA 11.8 and Python 3.10 packages. It also includes some minor file renames. Depends on rapidsai/raft#1120 Authors: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) - AJ Schmidt (https://github.com/ajschmidt8) - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) - William Hicks (https://github.com/wphicks) - Victor Lafargue (https://github.com/viclafargue) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#5120
This PR updates
cuml
to build against branch cuda-118 of theshared-action-workflow
repository.That branch contains updates for CUDA 11.8 and Python 3.10 packages.
It also includes some minor file renames.
Depends on rapidsai/raft#1120