Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to scikit-build-core #325

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 8, 2023

Contributes to rapidsai/build-planning#2

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 8, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from c9aa5a1 to 94942cb Compare December 12, 2023 22:35
@vyasr vyasr marked this pull request as ready for review December 12, 2023 23:19
@vyasr vyasr requested review from a team as code owners December 12, 2023 23:19
@vyasr vyasr added breaking Introduces a breaking change and removed non-breaking Introduces a non-breaking change labels Dec 12, 2023
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @vyasr

@vyasr
Copy link
Contributor Author

vyasr commented Dec 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit c6e6456 into rapidsai:branch-24.02 Dec 14, 2023
33 checks passed
@vyasr vyasr deleted the feat/scikit_build_core branch December 14, 2023 17:26
@madsbk madsbk mentioned this pull request Feb 1, 2024
rapids-bot bot pushed a commit that referenced this pull request Feb 1, 2024
Update the build script to support #325

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants