Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-cython & other more recent best practices #186

Closed
jakirkham opened this issue Mar 27, 2023 · 4 comments
Closed

Use rapids-cython & other more recent best practices #186

jakirkham opened this issue Mar 27, 2023 · 4 comments

Comments

@jakirkham
Copy link
Member

jakirkham commented Mar 27, 2023 •
edited
Loading

Would it make sense to start using rapids-cython here as in cuDF?

https://github.com/rapidsai/cudf/blob/766af666575b5db6f265e1fbf6466ccfd46eae30/python/cudf/CMakeLists.txt#L72

Any other best practices we should adopt here to modernize our scikit-build/CMake files?

Maybe some of these items are worth addressing ( #58 (comment) )
@jakirkham
Copy link
Member Author

cc @vyasr @robertmaynard

@jakirkham jakirkham mentioned this issue Mar 27, 2023
Merged
@vyasr
Copy link
Contributor

vyasr commented Mar 31, 2023

Yes it would be good to use rapids-cython and replace https://github.com/rapidsai/kvikio/blob/branch-23.04/python/cmake/kvikio_python_helpers.cmake

@vyasr
Copy link
Contributor

vyasr commented Mar 31, 2023

There are numerous other changes that have been made across RAPIDS that are somewhat related, such as moving away from setup.py towards pyproject.toml, using rapids-dependency-file-generator, and removing versioneer. Some of these are more relevant to scikit-build than others; the pyproject.toml migration will eventually be necessary to use the modern incarnation of scikit-build, which is a purely pyproject.toml, PEP 517-based builder.

@bdice bdice mentioned this issue Jun 5, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 7, 2023
@bdice
Migrate as much as possible to pyproject.toml, stop using versioneer …
4efb31c 
…to manage versions, update dependencies.yaml. (#232)

Modernizes kvikio's Python build system to help with CUDA 12 migration. Some of these changes were made for other RAPIDS repos in separate PRs over the course of time but I am doing them all together in this PR to help kvikio catch up to the state of other repos.

Major changes:
- Removed versioneer.
- Uses `pyproject.toml` for as much metadata as possible.
- Updates/copies/fixes/centralizes linter configurations for isort, mypy, etc.

Closes #194. Addresses some things mentioned in #186.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #232
@vyasr vyasr mentioned this issue Jul 28, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 28, 2023
@vyasr
Modernize Python build (#257)
8789aba 
Switch to using rapids-cmake's rapids-cython modules for the Python build. It also uses rapids-cuda to support NATIVE or RAPIDS as the list of CUDA architectures.

Resolves #186

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #257
@madsbk madsbk closed this as completed Jun 26, 2024
@jakirkham
Copy link
Member Author

Done in PR: #257

Though now using rapids-cython-core: #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madsbk @vyasr @jakirkham