Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Programming Language :: Python :: 3.10" #194

Closed
wants to merge 1 commit into from

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Apr 11, 2023

No description provided.

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 11, 2023
@jakirkham
Copy link
Member

Should we add python_requires = ">=3.8" as well (ref, under setup.py tab)?

@madsbk
Copy link
Member Author

madsbk commented Apr 11, 2023

Should we add python_requires = ">=3.8" as well (ref, under setup.py tab)?

I don't know which is the best place to put this?
Currently, we have it in setup.cfg but is it better to have it in setup.py or in pyproject.toml or in all of them?
AFAICT, cuDF has it in pyproject.toml only.

@madsbk madsbk marked this pull request as ready for review April 11, 2023 12:28
@bdice
Copy link
Contributor

bdice commented Apr 17, 2023

@madsbk All project information should migrate from setup.py and setup.cfg to pyproject.toml. That is the direction that the Python community is headed, and it's what we're striving for in RAPIDS. @vyasr can probably note the small number of exceptions where we cannot yet use pyproject.toml.

@vyasr
Copy link
Contributor

vyasr commented Apr 19, 2023

The current state of the art is captured fairly well in the pyproject.toml files of any of the core RAPIDS repos e.g. cudf or raft. This part of the scikit-build documentation lists which parameters need to stay in setup.py. Everything else can go into pyproject.toml. The only addendum is, don't use MANIFEST.in files for now (see scikit-build/scikit-build#886).

@madsbk madsbk changed the base branch from branch-23.06 to branch-23.08 June 1, 2023 10:40
@rapids-bot rapids-bot bot closed this in #232 Jun 7, 2023
rapids-bot bot pushed a commit that referenced this pull request Jun 7, 2023
…to manage versions, update dependencies.yaml. (#232)

Modernizes kvikio's Python build system to help with CUDA 12 migration. Some of these changes were made for other RAPIDS repos in separate PRs over the course of time but I am doing them all together in this PR to help kvikio catch up to the state of other repos.

Major changes:
- Removed versioneer.
- Uses `pyproject.toml` for as much metadata as possible.
- Updates/copies/fixes/centralizes linter configurations for isort, mypy, etc.

Closes #194. Addresses some things mentioned in #186.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #232
@madsbk madsbk deleted the ci_test branch June 14, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants