-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate as much as possible to pyproject.toml #5251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall (one potential issue commented in-line), but I tested the ci/release/update-version.sh
script with bash ./ci/release/update-version.sh 23.06
and it yielded non-sensical results for the dependencies.yaml
file:
diff --git a/dependencies.yaml b/dependencies.yaml
index 2e4704b5b..d5bac132e 100644
--- a/dependencies.yaml
+++ b/dependencies.yaml
@@ -73,11 +73,11 @@ dependencies:
packages:
- c-compiler
- cxx-compiler
- - libcumlprims=23.04.*
- - libraft-headers=23.04.*
- - libraft-distance=23.04.*
- - libraft-nn=23.04.*
- - rmm=23.04.*
+ - libcumlprims=23.063.063.04.*
+ - libraft-headers=23.063.063.04.*
+ - libraft-distance=23.063.063.04.*
+ - libraft-nn=23.063.063.04.*
+ - rmm=23.063.063.04.*
@csadorf can you make sure that you have all tag available locally ( This may be partly due to needing to refresh your cuml repo due to that recent rebase of the main branch invalidating a bunch of git refs, including old tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
Indeed, that was the issue. After re-fetching all tags with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
Move most Python package information from setup.py into pyproject.toml and MANIFEST.in.