Switch to scikit-build-core (#325)

Contributes to rapidsai/build-planning#2

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Mads R. B. Kristensen (https://github.com/madsbk)

URL: #325

conda/environments/all_cuda-118_arch-x86_64.yaml

@@ -32,7 +32,7 @@ dependencies:
 - pytest
 - pytest-cov
 - python>=3.9,<3.11
-- scikit-build>=0.13.1
+- scikit-build-core>=0.7.0
 - sphinx
 - sphinx-click
 - sphinx_rtd_theme

conda/environments/all_cuda-120_arch-x86_64.yaml

@@ -31,7 +31,7 @@ dependencies:
 - pytest
 - pytest-cov
 - python>=3.9,<3.11
-- scikit-build>=0.13.1
+- scikit-build-core>=0.7.0
 - sphinx
 - sphinx-click
 - sphinx_rtd_theme

conda/recipes/kvikio/meta.yaml

@@ -63,7 +63,7 @@ requirements:
     {% endif %}
     - cuda-version ={{ cuda_version }}
     - nvcomp {{ nvcomp_version }}
-    - scikit-build >=0.13.1
+    - scikit-build-core >=0.7.0
     - libkvikio ={{ version }}
   run:
     - python

dependencies.yaml

@@ -7,6 +7,7 @@ files:
       arch: [x86_64]
     includes:
       - build
+      - build_legate_wheel
       - checks
       - cudatoolkit
       - docs
@@ -65,6 +66,7 @@ files:
       table: build-system
     includes:
       - build
+      - build_legate_wheel
   legate_py_run:
     output: pyproject
     pyproject_dir: legate
@@ -94,15 +96,14 @@ dependencies:
           - cmake>=3.26.4
           - cython>=3.0.0
           - ninja
-          - scikit-build>=0.13.1
       - output_types: conda
         packages:
           - c-compiler
           - cxx-compiler
+          - scikit-build-core>=0.7.0
       - output_types: [requirements, pyproject]
         packages:
-          - setuptools
-          - wheel
+          - scikit-build-core[pyproject]>=0.7.0
     specific:
       - output_types: conda
         matrices:
@@ -133,6 +134,12 @@ dependencies:
             packages:
               - cuda-version=12.0
               - cuda-nvcc
+  build_legate_wheel:
+    common:
+      - output_types: [requirements, pyproject]
+        packages:
+          - setuptools
+          - wheel
   checks:
     common:
       - output_types: [conda, requirements]

legate/pyproject.toml

@@ -7,7 +7,7 @@ requires = [
     "cmake>=3.26.4",
     "cython>=3.0.0",
     "ninja",
-    "scikit-build>=0.13.1",
+    "scikit-build-core[pyproject]>=0.7.0",
     "setuptools",
     "wheel",
 ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../dependencies.yaml and run `rapids-dependency-file-generator`.

python/CMakeLists.txt

@@ -25,11 +25,7 @@ rapids_cuda_init_architectures(kvikio-python)
 project(
   kvikio-python
   VERSION ${kvikio_version}
-  LANGUAGES # TODO: Building Python extension modules via the python_extension_module requires the C
-            # language to be enabled here. The test project that is built in scikit-build to verify
-            # various linking options for the python library is hardcoded to build with C, so until
-            # that is fixed we need to keep C.
-            C CXX CUDA
+  LANGUAGES CXX CUDA
 )
 
 option(FIND_KVIKIO_CPP
@@ -53,7 +49,7 @@ if(NOT KvikIO_FOUND)
   install(TARGETS kvikio DESTINATION ${cython_lib_dir})
 endif()
 
-include(rapids-cython)
+include(rapids-cython-core)
 rapids_cython_init()
 
 add_subdirectory(cmake)

python/README.md

@@ -0,0 +1 @@
+../README.md

python/pyproject.toml

@@ -2,14 +2,12 @@
 # See file LICENSE for terms.
 
 [build-system]
-build-backend = "setuptools.build_meta"
+build-backend = "scikit_build_core.build"
 requires = [
     "cmake>=3.26.4",
     "cython>=3.0.0",
     "ninja",
-    "scikit-build>=0.13.1",
-    "setuptools",
-    "wheel",
+    "scikit-build-core[pyproject]>=0.7.0",
 ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../dependencies.yaml and run `rapids-dependency-file-generator`.
 
 [project]
@@ -109,3 +107,11 @@ ignore_missing_imports = true
 
 [project.entry-points."numcodecs.codecs"]
 nvcomp_batch = "kvikio.nvcomp_codec:NvCompBatchCodec"
+
+[tool.scikit-build]
+build-dir = "build/{wheel_tag}"
+cmake.build-type = "Release"
+cmake.minimum-version = "3.26.4"
+ninja.make-fallback = true
+sdist.reproducible = true
+wheel.packages = ["kvikio"]