Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Update numba versioning to pull 0.51 #109

Merged
merged 2 commits into from
Aug 20, 2020
Merged

ENH Update numba versioning to pull 0.51 #109

merged 2 commits into from
Aug 20, 2020

Conversation

mike-wendt
Copy link
Contributor

From successful GPU unit tests in rapidsai/cudf#5979 we are going to remove the restriciton that prevents use of numba 0.51 given the earlier timeout issues are resolve. Numba 0.51 brings CUDA 11 and Ampere support.

@mike-wendt
ENH Update numba versioning to pull 0.51
11f3fca 
From successful GPU unit tests in rapidsai/cudf#5979 we are going to remove the restriciton that prevents use of numba 0.51 given the earlier timeout issues are resolve. Numba 0.51 brings CUDA 11 and Ampere support.
@mike-wendt mike-wendt added 3 - Ready for Review Ready for review by team 4 - Needs Tests Waiting for test results to make a decision labels Aug 17, 2020
@mike-wendt mike-wendt requested a review from a team as a code owner August 17, 2020 18:54
@mike-wendt mike-wendt self-assigned this Aug 17, 2020
@mike-wendt mike-wendt added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 17, 2020
@mike-wendt
Copy link
Contributor Author

Adding DO NOT MERGE given the discussion about failures for aarch64 brought up by @jakirkham in conda-forge/numba-feedstock#56

Need a decision to how to proceed

@jakirkham
Copy link
Member

Looks like it is related to an issue with TBB. Disabling TBB on aarch64 got rid of the segfaults. Packages are now being published with that change.

@mike-wendt mike-wendt removed the 3 - Ready for Review Ready for review by team label Aug 18, 2020
@mike-wendt
Copy link
Contributor Author

Awaiting #111 to merge first and final sign off to merge this PR

@mike-wendt
Copy link
Contributor Author

rerun tests

jakirkham
jakirkham approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had one clarifying question above.

conda/recipes/versions.yaml Outdated
@@ -90,7 +90,7 @@ networkx_version:
nodejs_version:
- '>=12'
numba_version:
- '>=0.49,<0.51'
- '>=0.49'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to allow Numba 0.51 or do we want to require it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just allow it

@AjayThorve AjayThorve mentioned this pull request Aug 18, 2020
Merged
kkraus14
kkraus14 suggested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was discovered Numba 0.51 breaks all usage of LocalCUDACluster and dask-cuda-worker

@jakirkham
Copy link
Member

jakirkham commented Aug 18, 2020 •
edited
Loading

Fixes are being worked on in these PRs:

rapidsai/dask-cuda#379
numba/numba#6147

@mike-wendt
Copy link
Contributor Author

From our discussion today we will update the versioning to ignore 0.51.0 so when 0.51.1 is released we can use it.

@mike-wendt mike-wendt added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Aug 19, 2020
@mike-wendt
Copy link
Contributor Author

@kkraus14 can you re-review

@jakirkham
Copy link
Member

Sounds good. Thanks Mike! 😀

@mike-wendt mike-wendt added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Reviewer Waiting for reviewer to review or respond 4 - Needs Tests Waiting for test results to make a decision labels Aug 20, 2020
@mike-wendt mike-wendt merged commit 44168a1 into branch-0.15 Aug 20, 2020
@mike-wendt mike-wendt deleted the enh-numba-051 branch August 20, 2020 05:04
@galipremsagar galipremsagar mentioned this pull request Aug 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@mike-wendt mike-wendt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mike-wendt @jakirkham @kkraus14 @ajschmidt8