Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RAPIDS_NO_INITIALIZE at the top of CUDAWorker/LocalCUDACluster #379

Merged

Conversation

pentschev
Copy link
Member

Fix issue with dask-cuda-worker initializing on GPU 0 only.

@pentschev pentschev requested a review from a team as a code owner August 18, 2020 20:28
@pentschev pentschev changed the title Set RMM_NO_INITIALIZE if rmm_pool_size is undefined in CUDAWorker Set RAPIDS_NO_INITIALIZE if rmm_pool_size is undefined in CUDAWorker Aug 18, 2020
@pentschev pentschev force-pushed the fix-cuda-worker-rmm-no-initialize branch from fd87918 to 15abd71 Compare August 18, 2020 20:46
@pentschev pentschev changed the title Set RAPIDS_NO_INITIALIZE if rmm_pool_size is undefined in CUDAWorker Set RAPIDS_NO_INITIALIZE at the top of CUDAWorker/LocalCUDACluster Aug 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #379 into branch-0.15 will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15     #379      +/-   ##
===============================================
- Coverage        60.13%   60.10%   -0.03%     
===============================================
  Files               17       17              
  Lines             1342     1336       -6     
===============================================
- Hits               807      803       -4     
+ Misses             535      533       -2     
Impacted Files Coverage Δ
dask_cuda/benchmarks/utils.py 0.00% <ø> (ø)
dask_cuda/initialize.py 92.59% <ø> (-0.75%) ⬇️
dask_cuda/utils.py 87.31% <ø> (-0.10%) ⬇️
dask_cuda/cuda_worker.py 72.50% <100.00%> (ø)
dask_cuda/local_cuda_cluster.py 83.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b450a1e...7004e0b. Read the comment docs.

@quasiben
Copy link
Member

@peter pointed out his problem probably happens because dask will import cuDF serialization code

@pentschev
Copy link
Member Author

rerun tests

@jakirkham jakirkham merged commit ec216ee into rapidsai:branch-0.15 Aug 18, 2020
@jakirkham
Copy link
Member

Thanks Peter! 😄

@pentschev
Copy link
Member Author

Thanks for reviews everyone! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants