numba v0.51.0 #56

regro-cf-autotick-bot · 2020-08-12T21:21:02Z

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot.

The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

This PR was generated by https://circleci.com/gh/regro/circle_worker/38692, please use this URL for debugging}

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
tbb	2020.3

…da-forge-pinning 2020.08.12.16.30.22

conda-forge-linter · 2020-08-12T21:21:07Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This is required by `numba` version `0.51.0` as noted by the link below. https://github.com/numba/numba/blob/3a14664a0d7fb1ffdf086e9d02b715e1e2d0e0b3/setup.py#L15-L16

recipe/meta.yaml

jakirkham · 2020-08-13T23:55:49Z

@conda-forge-admin, please restart CI.

jakirkham · 2020-08-14T18:57:07Z

Looks like there is a casting error in the tests.

======================================================================
ERROR: test_ediff1d_edge_cases (numba.tests.test_np_functions.TestNPFunctions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/numba_1597363055369/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.8/site-packages/numba/tests/test_np_functions.py", line 2080, in test_ediff1d_edge_cases
    _check_raises_type_error(params, 'to_begin')
  File "/home/conda/feedstock_root/build_artifacts/numba_1597363055369/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.8/site-packages/numba/tests/test_np_functions.py", line 2047, in _check_raises_type_error
    pyfunc(**params)
  File "/home/conda/feedstock_root/build_artifacts/numba_1597363055369/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.8/site-packages/numba/tests/test_np_functions.py", line 233, in ediff1d
    return np.ediff1d(ary, to_end, to_begin)
  File "<__array_function__ internals>", line 5, in ediff1d
  File "/home/conda/feedstock_root/build_artifacts/numba_1597363055369/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.8/site-packages/numpy/lib/arraysetops.py", line 107, in ediff1d
    raise TypeError("dtype of `to_end` must be compatible "
TypeError: dtype of `to_end` must be compatible with input `ary` under the `same_kind` rule.

More details can be found on CI or in the attached logs.

cc @stuartarchibald (in case you have thoughts here 🙂)

stuartarchibald · 2020-08-14T19:05:15Z

Thanks @jakirkham this is a NumPy 1.19 vs Numba problem I think, xref numba/numba#5929 think it was Numba that hit the problem in NumPy in the first place :)

jakirkham · 2020-08-14T20:09:02Z

recipe/meta.yaml

-    - numpy >=1.15
+    # Working around an issue with NumPy 1.19
+    # xref: https://github.com/numba/numba/issues/5929
+    - numpy >=1.15,<1.19


xref: numba/numba#5929

IIUC, ref. numba/numba#5929 (comment), this is fixed in 1.19.1, so we could do

Suggested change

- numpy >=1.15

# Working around an issue with NumPy 1.19

# xref: https://github.com/numba/numba/issues/5929

- numpy >=1.15,<1.19

# Working around an issue with NumPy 1.19.0

# xref: https://github.com/numba/numba/issues/5929

- numpy >=1.15,!=1.19.0

Or did I miss something?

I don't know. Asked here ( numba/numba#5929 (comment) ).

That said, this is just in the tests. So I don't think we need to worry about this too much. Hoping by the next Numba release we will be able to drop this.

jakirkham · 2020-08-14T20:09:58Z

Thanks for the context Stuart! 😄

Went ahead and constrained NumPy to 1.18 in the tests only. Please let me know if that's a reasonable solution 🙂

github-actions · 2020-08-14T23:18:24Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
drone: passed
travis: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

jakirkham · 2020-08-15T00:08:10Z

Windows Python 3.8 is failing as we don't have corresponding llvmlite packages ~~( conda-forge/llvmlite-feedstock#40 )~~ ( conda-forge/llvmlite-feedstock#44 ).

PPC seems to have a segfault during the test suite, but only on Python 3.7 and 3.8 (3.6 appears to be fine).

numba/tests/test_parfors.py", line 150 in check_parfors_vs_others

step21 · 2020-08-15T10:05:40Z

PPC seems to have a segfault during the test suite, but only on Python 3.7 and 3.8 (3.6 appears to be fine).
numba/tests/test_parfors.py", line 150 in check_parfors_vs_others

same for aarch64. What did you do to make it pass now for ppc?

mbargull · 2020-08-15T15:22:46Z

recipe/meta.yaml

    - numpy
    - tbb-devel >=2019.5  # [linux]

  run:
    - python
-    - llvmlite >=0.33.0,<0.34
+    - llvmlite >=0.34.0,<0.35
    - {{ pin_compatible('numpy') }}


Shouldn't we use

Suggested change

- {{ pin_compatible('numpy') }}

- {{ pin_compatible('numpy') }}

# Working around an issue with NumPy 1.19.0

# xref: https://github.com/numba/numba/issues/5929

- numpy !=1.19.0

instead of adding the restriction to test/requires in https://github.com/conda-forge/numba-feedstock/pull/56/files#r470998911?

It seems it is just one niche case where it fails ( #56 (comment) ). So this seems too restrictive given that.

jakirkham · 2020-08-15T18:36:16Z

Not sure. Maybe it was restarted?

jakirkham · 2020-08-17T19:25:21Z

I wonder if the parfors segfault is related to issue ( numba/numba#5973 ). @stuartarchibald, do you have any insights here?

See if the segfaults on `aarch64` can be alleviated by not using `tbb` there.

jakirkham · 2020-08-17T22:57:27Z

I wonder if the parfors segfault is related to issue ( numba/numba#5973 ). @stuartarchibald, do you have any insights here?

Dropping tbb on aarch64 to see if this fixes the issue. Looks promising thus far.

jakirkham · 2020-08-18T00:21:31Z

Looks like that did the trick! 🎉

If there's anything we should follow up on, please let us know and we can handle it in a new PR. Thanks all! 😄

stuartarchibald · 2020-08-18T07:48:57Z

@jakirkham just got to this, thanks for getting the 0.51 build out.

That the tbb backend is segfaulting is obviously not good. Recording the backtraces in case the logs go missing:

AArch64 + Python 3.8:

Backtrace:
/lib64/libpthread.so.0(raise+0x34)[0xffff90ca7850]
??:0(??)[0xffff90d1b66c]
$PREFIX/lib/python3.8/lib-dynload/../../libtbb.so.2(+0x21dbc)[0xffff88196dbc]
$PREFIX/lib/python3.8/lib-dynload/../../libtbb.so.2(_ZNK3tbb8internal32allocate_root_with_context_proxy8allocateEm+0x54)[0xffff8818dd6c]
$PREFIX/lib/python3.8/site-packages/numba/np/ufunc/tbbpool.cpython-38-aarch64-linux-gnu.so(+0x5ad0)[0xffff88138ad0]
$PREFIX/lib/python3.8/lib-dynload/../../libtbb.so.2(_ZNK3tbb10interface78internal15task_arena_base16internal_executeERNS1_13delegate_baseE+0x194)[0xffff88195494]
$PREFIX/lib/python3.8/site-packages/numba/np/ufunc/tbbpool.cpython-38-aarch64-linux-gnu.so(+0x62e0)[0xffff881392e0]
??:0(??)[0xffff7f74c0ec]
??:0(??)[0xffff7f74c1e4]
python(+0x82380)[0xaaaad0ad7380]

AArch64 + Python 3.7:

Backtrace:
/lib64/libpthread.so.0(raise+0x34)[0xffffb8a54850]
??:0(??)[0xffffb8ac866c]
$PREFIX/lib/python3.7/lib-dynload/../../libtbb.so.2(+0x21dbc)[0xffff6c76bdbc]
$PREFIX/lib/python3.7/lib-dynload/../../libtbb.so.2(_ZNK3tbb8internal32allocate_root_with_context_proxy8allocateEm+0x54)[0xffff6c762d6c]
$PREFIX/lib/python3.7/site-packages/numba/np/ufunc/tbbpool.cpython-37m-aarch64-linux-gnu.so(+0x5ad0)[0xffff6c710ad0]
$PREFIX/lib/python3.7/lib-dynload/../../libtbb.so.2(_ZNK3tbb10interface78internal15task_arena_base16internal_executeERNS1_13delegate_baseE+0x194)[0xffff6c76a494]
$PREFIX/lib/python3.7/site-packages/numba/np/ufunc/tbbpool.cpython-37m-aarch64-linux-gnu.so(+0x62e0)[0xffff6c7112e0]
??:0(??)[0xffffadfaf0ec]
??:0(??)[0xffffadfaf1dc]
python(PyCFunction_Call+0x14c)[0xaaaae198ebf4]

I wonder if the parfors segfault is related to issue ( numba/numba#5973 ). @stuartarchibald, do you have any insights here?

I'd say quite it's likely. It's not clear what the problem is there, whether it's an issue with Numba or TBB. Slightly suspect it's to do with task isolation but that's just a guess.

jakirkham · 2020-08-18T08:24:32Z

Good point. Went ahead and attached the logs in this archive from the last failing build before dropping TBB on aarch64.

One interesting observation is that Python 3.6 avoided this issue. Not sure if we just got lucky there or if there's something notable about how Python 3.6 behaves relative to Python 3.7 and 3.8.

Thanks for taking a look Stuart! Please let us know if there's anything else you need here 😄

regro-cf-autotick-bot added 2 commits August 12, 2020 21:20

updated v0.51.0

f22ebd5

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.7.9, and con…

0c25a54

…da-forge-pinning 2020.08.12.16.30.22

regro-cf-autotick-bot requested review from henryiii, jakirkham, marcelotrevisani, mbargull, souravsingh and step21 as code owners August 12, 2020 21:21

Bump llvmlite to 0.34.0

231c93e

This is required by `numba` version `0.51.0` as noted by the link below. https://github.com/numba/numba/blob/3a14664a0d7fb1ffdf086e9d02b715e1e2d0e0b3/setup.py#L15-L16

jakirkham reviewed Aug 12, 2020

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

conda-forge-linter closed this Aug 13, 2020

conda-forge-linter reopened this Aug 13, 2020

Require NumPy pre-1.19 for testing

a8fab16

jakirkham reviewed Aug 14, 2020

View reviewed changes

jakirkham added the automerge Merge the PR when CI passes label Aug 14, 2020

mbargull reviewed Aug 15, 2020

View reviewed changes

mike-wendt mentioned this pull request Aug 17, 2020

ENH Update numba versioning to pull 0.51 rapidsai/integration#109

Merged

Try skipping use of tbb on aarch64

02973ab

See if the segfaults on `aarch64` can be alleviated by not using `tbb` there.

github-actions bot merged commit 36339a5 into conda-forge:master Aug 17, 2020

regro-cf-autotick-bot deleted the 0.51.0_h3ad951 branch August 17, 2020 23:57

jakirkham mentioned this pull request Aug 27, 2020

numba v0.51.1 #57

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

numba v0.51.0 #56

numba v0.51.0 #56

regro-cf-autotick-bot commented Aug 12, 2020

conda-forge-linter commented Aug 12, 2020

jakirkham commented Aug 13, 2020

jakirkham commented Aug 14, 2020

stuartarchibald commented Aug 14, 2020

jakirkham Aug 14, 2020

mbargull Aug 15, 2020

jakirkham Aug 17, 2020

jakirkham commented Aug 14, 2020

github-actions bot commented Aug 14, 2020 •

edited

Loading

jakirkham commented Aug 15, 2020 •

edited

Loading

step21 commented Aug 15, 2020

mbargull Aug 15, 2020

jakirkham Aug 15, 2020

jakirkham commented Aug 15, 2020

jakirkham commented Aug 17, 2020

jakirkham commented Aug 17, 2020

jakirkham commented Aug 18, 2020

stuartarchibald commented Aug 18, 2020

jakirkham commented Aug 18, 2020

numba v0.51.0 #56

numba v0.51.0 #56

Conversation

regro-cf-autotick-bot commented Aug 12, 2020

conda-forge-linter commented Aug 12, 2020

jakirkham commented Aug 13, 2020

jakirkham commented Aug 14, 2020

stuartarchibald commented Aug 14, 2020

jakirkham Aug 14, 2020

Choose a reason for hiding this comment

mbargull Aug 15, 2020

Choose a reason for hiding this comment

jakirkham Aug 17, 2020

Choose a reason for hiding this comment

jakirkham commented Aug 14, 2020

github-actions bot commented Aug 14, 2020 • edited Loading

jakirkham commented Aug 15, 2020 • edited Loading

step21 commented Aug 15, 2020

mbargull Aug 15, 2020

Choose a reason for hiding this comment

jakirkham Aug 15, 2020

Choose a reason for hiding this comment

jakirkham commented Aug 15, 2020

jakirkham commented Aug 17, 2020

jakirkham commented Aug 17, 2020

jakirkham commented Aug 18, 2020

stuartarchibald commented Aug 18, 2020

jakirkham commented Aug 18, 2020

github-actions bot commented Aug 14, 2020 •

edited

Loading

jakirkham commented Aug 15, 2020 •

edited

Loading