Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Dask's shuffle_method kwarg #1300

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Update to Dask's shuffle_method kwarg #1300

merged 1 commit into from
Jan 4, 2024

Conversation

pentschev
Copy link
Member

dask/dask#10738 has deprecated the shuffle kwarg in favor of shuffle_method which now raises a FutureWarning. This change transitions to the new kwarg.

Requires rapidsai/cudf#14708 .

@pentschev
Update to Dask's shuffle_method kwarg
f33324b 
dask/dask#10738 has deprecated the `shuffle`
kwarg in favor of `shuffle_method` which now raises a `FutureWarning`.
This change transitions to the new kwarg.
@pentschev pentschev added bug Something isn't working 0 - Blocked Cannot progress due to external reasons breaking Breaking change labels Jan 4, 2024
@pentschev pentschev requested a review from a team as a code owner January 4, 2024 09:48
@github-actions github-actions bot added the python python code needed label Jan 4, 2024
@pentschev pentschev added non-breaking Non-breaking change and removed python python code needed breaking Breaking change labels Jan 4, 2024
rjzamora
rjzamora approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev

dask_cuda/explicit_comms/dataframe/shuffle.py Show resolved Hide resolved
@pentschev pentschev added 3 - Ready for Review Ready for review by team and removed 0 - Blocked Cannot progress due to external reasons labels Jan 4, 2024
@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a3c9fec into rapidsai:branch-24.02 Jan 4, 2024
25 checks passed
@rjzamora
Copy link
Member

rjzamora commented Jan 4, 2024

Thanks @pentschev !

@pentschev pentschev deleted the use-dask-shuffle_method branch January 5, 2024 16:18
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
@pentschev @younseojava
Update to Dask's shuffle_method kwarg (rapidsai#1300)
3fc04db 
dask/dask#10738 has deprecated the `shuffle` kwarg in favor of `shuffle_method` which now raises a `FutureWarning`. This change transitions to the new kwarg.

Requires rapidsai/cudf#14708 .

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

URL: rapidsai#1300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @rjzamora