Update to Dask's shuffle_method kwarg
#14708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dask/dask#10738 has deprecated the `shuffle` kwarg in favor of `shuffle_method` which now raises a `FutureWarning`. This change transitions to the new kwarg.
pentschev
added
bug
rjzamora
approved these changes
Jan 4, 2024
|
/merge |
|
Thanks for the review @rjzamora ! |
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Jan 4, 2024
dask/dask#10738 has deprecated the `shuffle` kwarg in favor of `shuffle_method` which now raises a `FutureWarning`. This change transitions to the new kwarg. Requires rapidsai/cudf#14708 . Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #1300
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
It seems that #14708 was a bit too aggressive in updating the `shuffle` kwarg to `shuffle_method`, and [gpu-CI is currently failing](dask/dask#10809) in dask/dask. This PR aligns dask-cudf with `dask.dataframe` by warning the user when the `shuffle` argument is used (rather than raising an error). I definitely don't think it makes sense for RAPIDS to be **more** strict than dask/dask about this argument. This also fixes a bug in `groupby.aggregate()` (where we were still using `shuffle=`) Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - https://github.com/jakirkham URL: #14762
younseojava
pushed a commit
to ROCm/dask-cuda-rocm
that referenced
this pull request
Apr 16, 2024
dask/dask#10738 has deprecated the `shuffle` kwarg in favor of `shuffle_method` which now raises a `FutureWarning`. This change transitions to the new kwarg. Requires rapidsai/cudf#14708 . Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Richard (Rick) Zamora (https://github.com/rjzamora) URL: rapidsai#1300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dask/dask#10738 has deprecated the
shufflekwarg in favor ofshuffle_methodwhich now raises aFutureWarning. This change transitions to the new kwarg.Description
Checklist