Skip to content

Commit

Permalink
Update to Dask's shuffle_method kwarg (#1300)
Browse files Browse the repository at this point in the history
dask/dask#10738 has deprecated the `shuffle` kwarg in favor of `shuffle_method` which now raises a `FutureWarning`. This change transitions to the new kwarg.

Requires rapidsai/cudf#14708 .

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

URL: #1300
  • Loading branch information
pentschev authored Jan 4, 2024
1 parent 0f34116 commit a3c9fec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dask_cuda/explicit_comms/dataframe/shuffle.py
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def wrapper(*args, **kwargs):
kw = kw.arguments
# Notice, we only overwrite the default and the "tasks" shuffle
# algorithm. The "disk" and "p2p" algorithm, we don't touch.
if kw["shuffle"] in ("tasks", None):
if kw["shuffle_method"] in ("tasks", None):
col = kw["col"]
if isinstance(col, str):
col = [col]
Expand Down
2 changes: 1 addition & 1 deletion dask_cuda/tests/test_proxify_host_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def is_proxy_object(x):
ddf = dask.dataframe.from_pandas(
cudf.DataFrame({"key": np.arange(10)}), npartitions=npartitions
)
res = ddf.shuffle(on="key", shuffle="tasks").persist()
res = ddf.shuffle(on="key", shuffle_method="tasks").persist()

# With compatibility mode on, we shouldn't encounter any proxy objects
if compatibility_mode:
Expand Down

0 comments on commit a3c9fec

Please sign in to comment.