Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libfaiss runtime dependency to libcuml. #5284

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add libfaiss runtime dependency to libcuml. #5284

merged 2 commits into from
Mar 20, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 20, 2023

Fixes an issue with #5281

libfaiss is required at runtime, and thus must be specified as a libcuml runtime dependency.

@bdice bdice requested a review from a team as a code owner March 20, 2023 16:20
@github-actions github-actions bot added the conda conda issue label Mar 20, 2023
@bdice
Copy link
Contributor Author

bdice commented Mar 20, 2023

cc: @cjnolet @charlesbluca

cjnolet
cjnolet approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 20, 2023
charlesbluca
charlesbluca approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice!

@cjnolet cjnolet requested a review from a team as a code owner March 20, 2023 16:51
@cjnolet
Copy link
Member

cjnolet commented Mar 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6976c8b into rapidsai:branch-23.04 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@sevagh sevagh sevagh approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@bdice bdice

Labels
CMake conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @cjnolet @sevagh @charlesbluca