Move faiss_mr from raft #5281
Merged
Move faiss_mr from raft #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The faiss_mr file in RAFT is only currently used by the reachability_faiss code in cuml. Move this file over to allow us to completely remove the faiss dependency from RAFT.
benfred
added a commit
to benfred/raft
that referenced
this pull request
Mar 17, 2023
Remove faiss_mr.hpp - in favour of rapidsai/cuml#5281
cjnolet
approved these changes
Mar 17, 2023
jolorunyomi
approved these changes
Mar 17, 2023
cjnolet
approved these changes
Mar 17, 2023
cjnolet
added
improvement
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Mar 18, 2023
Remove faiss_mr.hpp - in favour of rapidsai/cuml#5281 Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #1351
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
Fixes an issue with #5281 libfaiss is required at runtime, and thus must be specified as a libcuml runtime dependency. Authors: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Charles Blackmon-Luca (https://github.com/charlesbluca) - Sevag H (https://github.com/sevagh) URL: #5284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The faiss_mr file in RAFT is only currently used by the reachability_faiss code in cuml. Move this file over to allow us to completely remove the faiss dependency from RAFT.