Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump async-trait from 0.1.66 to 0.1.67 in /dask_planner #1093

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2023

Bumps async-trait from 0.1.66 to 0.1.67.

Release notes

Sourced from async-trait's releases.

0.1.67

  • Update syn dependency to 2.x
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.66 to 0.1.67.
- [Release notes](https://github.com/dtolnay/async-trait/releases)
- [Commits](dtolnay/async-trait@0.1.66...0.1.67)

---
updated-dependencies:
- dependency-name: async-trait
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #1093 (b61dc2a) into main (11fda74) will increase coverage by 0.11%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
+ Coverage   80.90%   81.02%   +0.11%     
==========================================
  Files          78       78              
  Lines        4384     4384              
  Branches      787      787              
==========================================
+ Hits         3547     3552       +5     
+ Misses        666      657       -9     
- Partials      171      175       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charlesbluca
Copy link
Collaborator

Looks like the gpuCI failures are unrelated, and come up when trying to import cuML:

gpu = True

    @pytest.mark.parametrize("gpu", [False, pytest.param(True, marks=pytest.mark.gpu)])
    def test_ml_class_mappings(gpu):
        from dask_sql.physical.utils.ml_classes import get_cpu_classes, get_gpu_classes
        from dask_sql.utils import import_class
    
        try:
            import lightgbm
            import xgboost
        except KeyError:
            lightgbm = None
            xgboost = None
    
        classes_dict = get_gpu_classes() if gpu else get_cpu_classes()
    
        for key in classes_dict:
            if not ("XGB" in key and xgboost is None) and not (
                "LGBM" in key and lightgbm is None
            ):
>               import_class(classes_dict[key])

tests/unit/test_ml_utils.py:40: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
dask_sql/utils.py:189: in import_class
    module = importlib.import_module(module_path)
/opt/conda/envs/dask_sql/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:961: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:961: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:961: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:975: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:671: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:843: in exec_module
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/__init__.py:17: in <module>
    from cuml.internals.base import Base, UniversalBase
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/__init__.py:17: in <module>
    from cuml.internals.base_helpers import BaseMetaClass, _tags_class_and_instance
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/base_helpers.py:20: in <module>
    from cuml.internals.api_decorators import (
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/api_decorators.py:24: in <module>
    from cuml.internals import input_utils as iu
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/input_utils.py:19: in <module>
    from cuml.internals.array import CumlArray
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/array.py:22: in <module>
    from cuml.internals.global_settings import GlobalSettings
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/global_settings.py:19: in <module>
    from cuml.internals.available_devices import is_cuda_available
/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/available_devices.py:17: in <module>
    from cuml.internals.safe_imports import gpu_only_import_from, UnavailableError
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    import importlib
    import traceback
    from cuml.internals.device_support import CPU_ENABLED, GPU_ENABLED
>   from cuml.internals import logger
E   ImportError: libfaiss.so: cannot open shared object file: No such file or directory

/opt/conda/envs/dask_sql/lib/python3.8/site-packages/cuml/internals/safe_imports.py:21: ImportError

My best guess is that this is related to rapidsai/cuml#5281, going to look into it a bit more

@charlesbluca
Copy link
Collaborator

rerun tests

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 27, 2023

Superseded by #1096.

@dependabot dependabot bot closed this Mar 27, 2023
@dependabot dependabot bot deleted the dependabot/cargo/dask_planner/async-trait-0.1.67 branch March 27, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants