Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libfaiss runtime dependency to libcuml. #5284

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add libfaiss runtime dependency to libcuml. #5284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bcf3b6
Add libfaiss runtime dependency to libcuml.
bdice Mar 20, 2023
2065ffc
Making FAISS a private dependency
cjnolet Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions conda/recipes/libcuml/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ outputs:
- libraft-headers ={{ minor_version }}
- libraft-nn ={{ minor_version }}
- treelite {{ treelite_version }}
- libfaiss>=1.7.1
- faiss-proc=*=cuda
about:
home: https://rapids.ai/
license: Apache-2.0
Expand Down
4 changes: 2 additions & 2 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,8 @@ if(BUILD_CUML_CPP_LIBRARY)

# These are always private:
list(APPEND _cuml_cpp_private_libs
raft::raft
$<$<BOOL:${CUML_USE_RAFT_NN}>:faiss>
$<TARGET_NAME_IF_EXISTS:GPUTreeShap::GPUTreeShap>
$<$<BOOL:${LINK_CUFFT}>:CUDA::cufft${_ctk_static_suffix}>
${TREELITE_LIBS}
Expand All @@ -604,8 +606,6 @@ if(BUILD_CUML_CPP_LIBRARY)
# because cumlprims_mg and cuML inherit their CUDA libs from the raft::raft
# INTERFACE target.
list(APPEND ${_cuml_cpp_libs_var_name}
raft::raft
$<$<BOOL:${CUML_USE_RAFT_NN}>:faiss>
$<$<BOOL:${CUML_USE_RAFT_NN}>:raft::nn>
$<$<BOOL:${CUML_USE_RAFT_DIST}>:raft::distance>
$<TARGET_NAME_IF_EXISTS:cumlprims_mg::cumlprims_mg>
Expand Down