Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward merge 23.02 into 23.04 #5182

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Forward merge 23.02 into 23.04 #5182

merged 7 commits into from
Jan 31, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 30, 2023

Replaces #5179

@bdice
Build CUDA 11.8 and Python 3.10 Packages (#5120)
5dacb91 
This PR updates `cuml` to build against branch [cuda-118](https://github.com/rapidsai/shared-action-workflows/compare/cuda-118) of the `shared-action-workflow` repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - William Hicks (https://github.com/wphicks)
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #5120
@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Jan 30, 2023
@vyasr vyasr requested review from a team as code owners January 30, 2023 23:15
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue labels Jan 30, 2023
@vyasr vyasr added the non-breaking Non-breaking change label Jan 30, 2023
@vyasr vyasr changed the base branch from branch-23.02 to branch-23.04 January 30, 2023 23:16
@vyasr vyasr requested a review from a team as a code owner January 30, 2023 23:16
msadang
msadang approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@5efb58b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.04    #5182   +/-   ##
===============================================
  Coverage                ?   68.94%           
===============================================
  Files                   ?      192           
  Lines                   ?    12396           
  Branches                ?        0           
===============================================
  Hits                    ?     8546           
  Misses                  ?     3850           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

csadorf and others added 2 commits January 31, 2023 10:04
@csadorf
Disable hypothesis tests for 23.02 burndown. (#5168)
348a8cb 
Authors:
  - Carl Simon Adorf (https://github.com/csadorf)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #5168
@AjayThorve
Add docs build GH (#5155)
36e6756 
This PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

cc @ajschmidt8

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5155
@ajschmidt8
Copy link
Member

@vyasr, can you rebase and I will admin merge?

cjnolet and others added 3 commits January 31, 2023 16:13
@cjnolet
Adding benchmark notebook for hdbscan soft clustering (#5103)
fb4bab4 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5103
@ajschmidt8
Remove faiss from libcuml (#5175)
fee4ac8 
The version of `faiss` that's currently used by `libcuml` conflicts with the version used by `raft`.

After discussions with @dantegd and @cjnolet, it was determined that `cuml` should really just depend on `raft`'s version of `faiss` anyway.

Therefore, this PR removes `faiss` from `libcuml`.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #5175
@vyasr
Merge remote-tracking branch 'origin/branch-23.02' into branch-23.04-…
5d0a591 
…merge-23.02
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the ci label Jan 31, 2023
@ajschmidt8 ajschmidt8 merged commit 7aa7cc8 into rapidsai:branch-23.04 Jan 31, 2023
@vyasr vyasr deleted the branch-23.04-merge-23.02 branch January 31, 2023 18:34
AyodeAwe pushed a commit to AyodeAwe/cuml that referenced this pull request Feb 13, 2023
@ajschmidt8
Merge pull request rapidsai#5182 from vyasr/branch-23.04-merge-23.02
2f04f61 
Forward merge 23.02 into 23.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msadang msadang msadang approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
ci CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vyasr @codecov-commenter @ajschmidt8 @cjnolet @msadang @bdice @wphicks @csadorf @AjayThorve