Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Merge branch-24.06 into branch-24.08 #4454

Merged
merged 27 commits into from
Jun 4, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented May 31, 2024

Replaces #4433

raybellwaves and others added 24 commits May 20, 2024 21:09
* Remove the devcontainer when the VSCode window closes
* Adds a descriptive name to the running container:
  ```shell
  $ docker ps -a
  CONTAINER ID   IMAGE            ...  NAMES
  0dbb364fe544   vsc-cugraph-...  ...  rapids-cugraph-24.06-cuda12.2-conda
  
  $ docker rm -f rapids-cugraph-24.06-cuda12.2-conda
  ```

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Ralph Liu (https://github.com/nv-rliu)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4361
Closes rapidsai#4285

I'll report back if it get to render locally. Ran out of mem building the library on my ec2 machine (g5.2xlarge: 32 Gb RAM) but I did just build cudf. I'll try again soon.

~~Also brainstorming here and I probably should upstream this to the rapids CI process. Would be nice to have /ok to test docs which just builds the docs for this PR~~ created https://github.com/nv-gha-runners/nvidia-runners/issues/25

I tried building the docs locally and got

```
WARNING: [autosummary] failed to import cugraph.jaccard_w.
Possible hints:
* AttributeError: module 'cugraph' has no attribute 'jaccard_w'
* ImportError: 
* ModuleNotFoundError: No module named 'cugraph.jaccard_w'
WARNING: [autosummary] failed to import cugraph.overlap_w.
Possible hints:
* ModuleNotFoundError: No module named 'cugraph.overlap_w'
* ImportError: 
* AttributeError: module 'cugraph' has no attribute 'overlap_w'
WARNING: [autosummary] failed to import cugraph.sorensen_w.
Possible hints:
* ModuleNotFoundError: No module named 'cugraph.sorensen_w'
* ImportError: 
* AttributeError: module 'cugraph' has no attribute 'sorensen_w'
```

Think this comes from https://github.com/rapidsai/cugraph/blob/abe69c0419b67b567d3c8fce91ee1a062d53e385/docs/cugraph/source/api_docs/cugraph/link_prediction.rst#L14

but I may have messed up my build

Authors:
  - Ray Bell (https://github.com/raybellwaves)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#4323
Fix a bug in kv_store_t implementation

Authors:
  - Naim (https://github.com/naimnv)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: rapidsai#4434
Believe the path suggested previously is outdated.

Authors:
  - Ray Bell (https://github.com/raybellwaves)
  - Don Acosta (https://github.com/acostadon)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Don Acosta (https://github.com/acostadon)

URL: rapidsai#4327
Restructure to pass stream instead of handle and synchronize appropriately.

Closes rapidsai#4236

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#4275
This PR restructures the current sampling primitive implementation and adds biased sampling support.

Closes rapidsai#4288

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: rapidsai#4430
Closes rapidsai#4440

This PR updates `enable_batch` to use the updated implementation for `replicate_edgelist`.

Authors:
  - Ralph Liu (https://github.com/nv-rliu)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Joseph Nke (https://github.com/jnke2016)

URL: rapidsai#4441
Update size_ field of kv_cuco_store_t with correct values.

Authors:
  - Naim (https://github.com/naimnv)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#4444
This PR

1. Performs edge triangle count in chunk
2. Enables k - 1 core optimization
3. Add C++ tests for edge triangle count
4. Move edge triangle count to the stable API
5. Implement MG edge triangle count and add tests
6. Update 'mg_graph_to_sg_graph' to support 'edge_ids' along with tests

closes rapidsai#4370
closes rapidsai#4371

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#4382
**[WIP]** I'm using this PR to debug/add support for `DASK_DATAFRAME__QUERY_PLANNING=True`.

**NOTES**:
- Depends on dask/dask-expr#1041 [Merged]
- Depends on dask/dask-expr#1044

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4325
This notebook will be used to demontstrate how to  use nx-cugraph and show the speed-up.

Authors:
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#4366
Similar to rapidsai/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Ralph Liu (https://github.com/nv-rliu)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Ray Bell (https://github.com/raybellwaves)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#4404
added content to document c++ algorithms and fixed links that were pointing to the previously removed content
resolves rapidsai#4431  
Resolves rapidsai#4116

Authors:
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Brad Rees (https://github.com/BradReesWork)
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: rapidsai#4435
Adding a tutorial to get started with cugraph.

There are more to follow but this is identified as an important one.

closes rapidsai#4385

Authors:
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#4396
Adds benchmark for `nx_cugraph.ego_graph`

_Note: this code is not part of any installed package and does not affect the release.  It is being added so it can be included in the `branch-24.06` sources for reference._

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Erik Welch (https://github.com/eriknw)

URL: rapidsai#4451
Distributed sampling in cuGraph-PyG.  Also renames the existing API to clarify that it is dask based.
Adds a dependency on `tensordict` for `cuGraph-PyG` which supports the new `TensorDictFeatureStore`.
Also no longer installs `torch-cluster` and `torch-spline-conv` in CI for testing since that results in an `ImportError` and neither of those packages are needed.

Requires PyG 2.5.  Should be merged after rapidsai#4335 

Merge after rapidsai#4355 

Closes rapidsai#4248 
Closes rapidsai#4249 
Closes rapidsai#3383 
Closes rapidsai#3942 
Closes rapidsai#3836 
Closes rapidsai#4202 
Closes rapidsai#4051 
Closes rapidsai#4326 
Closes rapidsai#4252 
Partially addresses rapidsai#3805

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Tingyu Wang (https://github.com/tingyu66)
  - Ralph Liu (https://github.com/nv-rliu)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - Brad Rees (https://github.com/BradReesWork)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#4384
@rlratzel rlratzel changed the base branch from branch-24.06 to branch-24.08 May 31, 2024 07:54
@rlratzel rlratzel requested review from a team as code owners May 31, 2024 07:54
Copy link

copy-pr-bot bot commented May 31, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cuGraph CMake benchmarks labels May 31, 2024
@rlratzel
Copy link
Contributor

/ok to test

@nv-rliu
Copy link
Contributor Author

nv-rliu commented May 31, 2024

Once this PR is merged, it should resolve the dependency error in the pip devcontainer build and unblock CI.
rapidsai/raft#2347

@jameslamb
Copy link
Member

Once this PR is merged, it should resolve the dependency error in the pip devcontainer build and unblock CI.
rapidsai/raft#2347

@nv-rliu that's been replaced by this one: rapidsai/raft#2349

@trxcllnt
Copy link
Collaborator

trxcllnt commented Jun 3, 2024

The cuda-11.8-pip and cuda12.2-pip devcontainer.json files need to be updated to match the changes in this PR:

@rlratzel
Copy link
Contributor

rlratzel commented Jun 3, 2024

/ok to test

@rlratzel rlratzel added the DO NOT MERGE Hold off on merging; see PR for details label Jun 3, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Jun 3, 2024

Added a DO NOT MERGE label to prevent accidental squash merging.
Ops, please remove the label when you're ready to properly merge.

@AyodeAwe AyodeAwe removed the DO NOT MERGE Hold off on merging; see PR for details label Jun 4, 2024
@AyodeAwe AyodeAwe merged commit 31f01ca into rapidsai:branch-24.08 Jun 4, 2024
131 checks passed
@nv-rliu nv-rliu deleted the branch-24.08-merge-24.06 branch June 4, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks ci CMake conda cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.