-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building cugraph with CCCL main #4404
Conversation
The new While this is possible in CCCL 2.2.0's version of I commented out the The problem case is when the Alternatively, I attempted to specialize the cc: @BradReesWork if you have any ideas or know the right person to help fix this. |
The nvcc error tells us half of the issue:
The error from clang tells us the other half:
Combining info from both errors, the issue is that when But |
@seunghwak is our expert in this area |
It looks like the main build is working, but the wheel builds are blocked by #4436? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Updates CCCL to v2.5.0 and a more recent cuCollections commit. Using cuco at [6923b3](NVIDIA/cuCollections@6923b3b) because it was before NVIDIA/cuCollections#479, which is a breaking change for libcudf. CCCL PR: * NVIDIA/cccl#1667 RAPIDS PRs: * rapidsai/cudf#15552 * rapidsai/cuml#5886 * rapidsai/cugraph#4404 * rapidsai/cuspatial#1382 Authors: - Paul Taylor (https://github.com/trxcllnt) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #607
Similar to rapidsai/cudf#15552, we are testing building RAPIDS with CCCL's main branch to get ahead of any breaking changes.