Forward-merge branch-23.08 to branch-23.10 #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #3675 and #3706 This PR moves the `datasets` API from experimental to stable. Users can now do: ```python from cugraph.datasets import karate G = karate.get_graph() ``` The existing `experimental.datasets` package has been updated with the `promoted_experimental_warning_wrapper()`. All notebooks, docstrings, and unit test dependencies on `datasets` have been updated to use the stable API. This PR also removes the networkx warning suppression from the unit tests. Authors: - ralph (https://github.com/nv-rliu) - Naim (https://github.com/naimnv) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Rick Ratzel (https://github.com/rlratzel) URL: #3712
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the |
This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]
…stores use of `setup.py` temporarily for develop builds (#3747) This PR adds the following: * Removes the now unnecessary "." path used in the install options when `--pydevelop` is used, which resulted in an error when called. * Temporarily adds a call to `setup.py bdist_ext --inplace` only when `--pydevelop` is used to workaround a [bug in scikit-build](scikit-build/scikit-build#981) when `setuptools>=64` is installed. Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Brad Rees (https://github.com/BradReesWork) - Vyas Ramasubramani (https://github.com/vyasr) URL: #3747
This PR builds on top of #3734 Merge after #3734 Todo tests for: - [x] _get_renumber_map - [x] _get_tensor_d_from_sampled_df - [x] create_homogeneous_sampled_graphs_from_dataframe - [x] pytests pass - [x] dataset_from_disk_cudf.ipynb (`obgn_products_sampling/`) - [x] Verify training benchmark Authors: - Vibhu Jawa (https://github.com/VibhuJawa) - Seunghwa Kang (https://github.com/seunghwak) - Chuck Hastings (https://github.com/ChuckHastings) - Alex Barghi (https://github.com/alexbarghi-nv) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) URL: #3742
…milarity (#3728) This PR - changes `per_v_pair_transform_dst_nbr_intersection` to support computing weighted intersection - updates implementation of `similarity`, `jaccard_coefficients`, `sorensen_coefficients`, `overlap_coefficients` for weighted graphs NOTE: current implementation doesn't support computing similarity for multi-edge graphs. closes #2748 closes #3477 Authors: - Naim (https://github.com/naimnv) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Seunghwa Kang (https://github.com/seunghwak) - Joseph Nke (https://github.com/jnke2016) URL: #3728
A customer identified an issue trying to run Jaccard. In MG calls they were seeing failed memory allocation calls. Vertices were being shuffled incorrectly in the C API, so we were getting vertices processed on the wrong GPU, resulting in out-of-bounds memory references. Moved the shuffle before renumbering, which puts vertices to be on proper GPU Closes #3746 Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: #3758
This PR pins `dask` & `distributed` to `2023.7.1` version for `23.08` release. xref: rapidsai/cudf#13802 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Brad Rees (https://github.com/BradReesWork) - Ray Douglass (https://github.com/raydouglass) - Peter Andreas Entschev (https://github.com/pentschev) URL: #3761
There was a misalignment between the `renumber_sampled_edgelist` function behavior and what PyG and DGL need. This PR fixes this. Authors: - Seunghwa Kang (https://github.com/seunghwak) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) URL: #3762
Several graph methods are failing, some being an effect of migrating away from cython.cu renumbering. This PR fixes couple graph methods and fixes the inconsistency in results returned by the SG and MG API closes #3740 closes #3766 Authors: - Joseph Nke (https://github.com/jnke2016) Approvers: - Brad Rees (https://github.com/BradReesWork) - Rick Ratzel (https://github.com/rlratzel) URL: #3757
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.10 #3755 +/- ##
===============================================
Coverage ? 67.78%
===============================================
Files ? 175
Lines ? 11974
Branches ? 0
===============================================
Hits ? 8117
Misses ? 3857
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.08that creates a PR to keepbranch-23.10up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.