Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the renumber_sampled_edgelist function behavior. #3762

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Change the renumber_sampled_edgelist function behavior. #3762

merged 7 commits into from
Aug 3, 2023

Conversation

seunghwak
Copy link
Contributor

There was a misalignment between the renumber_sampled_edgelist function behavior and what PyG and DGL need.

This PR fixes this.

@seunghwak seunghwak requested a review from a team as a code owner August 2, 2023 18:04
@seunghwak seunghwak self-assigned this Aug 2, 2023
@seunghwak seunghwak added breaking Breaking change bug Something isn't working labels Aug 2, 2023
@seunghwak seunghwak added this to the 23.08 milestone Aug 2, 2023
@alexbarghi-nv
Copy link
Member

alexbarghi-nv commented Aug 2, 2023 •
edited
Loading

@seunghwak is this PR ready yet? I'm still seeing the wrong behavior after trying sampling with the PR.
Never mind, after looking at the code changes, this is definitely not complete. I'll wait until you ping me.

alexbarghi-nv
alexbarghi-nv requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the issue with chunk size. Benchmarks succeed when ensuring num_chunks is >=1

cpp/src/sampling/renumber_sampled_edgelist_impl.cuh Outdated Show resolved Hide resolved
alexbarghi-nv
alexbarghi-nv approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit f6543f6 into rapidsai:branch-23.08 Aug 3, 2023
@seunghwak seunghwak deleted the bug_mfg branch August 21, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@seunghwak seunghwak

Labels
breaking Breaking change bug Something isn't working
Projects
None yet
Milestone
23.08
Development

Successfully merging this pull request may close these issues.
3 participants
@seunghwak @alexbarghi-nv @ChuckHastings