Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update primitive to compute weighted Jaccard, Sorensen and Overlap similarity #3728

Merged
merged 26 commits into from
Jul 31, 2023
Merged

Update primitive to compute weighted Jaccard, Sorensen and Overlap similarity #3728

merged 26 commits into from
Jul 31, 2023

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Jul 21, 2023 •
edited by ChuckHastings
Loading

This PR

  • changes per_v_pair_transform_dst_nbr_intersection to support computing weighted intersection
  • updates implementation of similarity, jaccard_coefficients, sorensen_coefficients, overlap_coefficients for weighted graphs

NOTE: current implementation doesn't support computing similarity for multi-edge graphs.

closes #2748
closes #3477

@naimnv naimnv requested review from a team as code owners July 21, 2023 15:12
@naimnv naimnv self-assigned this Jul 21, 2023
@naimnv naimnv added feature request New feature or request non-breaking Non-breaking change labels Jul 21, 2023
@naimnv naimnv changed the title Weighted similarity Upate primitive to compute weighted Jaccard, Sorsen and Ovelap similarity Jul 21, 2023
ChuckHastings
ChuckHastings reviewed Jul 24, 2023
View reviewed changes
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/jaccard_impl.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review part 1.

cpp/src/link_prediction/jaccard_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/overlap_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/sorensen_impl.cuh Outdated Show resolved Hide resolved
@ChuckHastings ChuckHastings changed the title Upate primitive to compute weighted Jaccard, Sorsen and Ovelap similarity Update primitive to compute weighted Jaccard, Sorensen and Overlap similarity Jul 24, 2023
@BradReesWork BradReesWork added this to the 23.08 milestone Jul 24, 2023
seunghwak
seunghwak reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Part 2/3

cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/per_v_pair_transform_dst_nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Part 3/3

cpp/tests/link_prediction/mg_weighted_similarity_test.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/mg_weighted_similarity_test.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/mg_weighted_similarity_test.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/mg_weighted_similarity_test.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/mg_weighted_similarity_test.cpp Show resolved Hide resolved
cpp/tests/link_prediction/similarity_compare.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/similarity_compare.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/similarity_compare.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/similarity_compare.cpp Outdated Show resolved Hide resolved
cpp/tests/link_prediction/similarity_compare.cpp Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review part1/2

cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/detail/nbr_intersection.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review Part 2/2

cpp/src/prims/per_v_pair_transform_dst_nbr_intersection.cuh Outdated Show resolved Hide resolved
cpp/src/prims/per_v_pair_transform_dst_nbr_intersection.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks!!!

@naimnv
Copy link
Contributor Author

naimnv commented Jul 30, 2023

Now @ChuckHastings can merge it :)

jnke2016
jnke2016 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I was following the change requested in this PR

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 14862c6 into rapidsai:branch-23.08 Jul 31, 2023
@jnke2016 jnke2016 mentioned this pull request Aug 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
23.08
Development

Successfully merging this pull request may close these issues.

Update primitive to support weighted similarity algorithms Weighted nbr intersection primitive
5 participants
@naimnv @ChuckHastings @seunghwak @jnke2016 @BradReesWork