Remove legacy renumbering #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.60% // Head: 53.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #2949 +/- ##
================================================
- Coverage 57.60% 53.77% -3.83%
================================================
Files 147 147
Lines 9227 9333 +106
================================================
- Hits 5315 5019 -296
- Misses 3912 4314 +402
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…2_remove-legacy-renum
BradReesWork
added
improvement
…2_remove-legacy-renum
…nd remove the cython.cu renumbering path
…2_remove-legacy-renum
…2_remove-legacy-renum
added 6 commits
April 3, 2023 17:58
added 4 commits
April 3, 2023 19:46
rlratzel
approved these changes
Apr 4, 2023
|
/merge |
…d multi-column vertices
…2_remove-legacy-renum
…rt import errors better.
…etworkx type in the type annotation to avoid depending on networkx.
…ype annotation to avoid depending on networkx.
|
/merge |
raydouglass
approved these changes
Apr 5, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
With the merge of PR #2949, we no longer need these calls in `cython.cu` Closes #3466 Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Joseph Nke (https://github.com/jnke2016) - Naim (https://github.com/naimnv) - Alex Barghi (https://github.com/alexbarghi-nv) - Rick Ratzel (https://github.com/rlratzel) - Seunghwa Kang (https://github.com/seunghwak) URL: #3467
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to removing
cython.curenumbering from our path, this PR migrate several SG altos to the PLC path.closes #2437
closes #1679
closes #2535
closes #2536
closes #2537
closes #3344