Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix exposed legacy_renum_only options in public graph APIs #2437

Closed
Tracked by #3304
rlratzel opened this issue Jul 21, 2022 · 1 comment · Fixed by #2949
Closed
Tracked by #3304

[BUG] Fix exposed legacy_renum_only options in public graph APIs #2437

rlratzel opened this issue Jul 21, 2022 · 1 comment · Fixed by #2949
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Jul 21, 2022

A change (still to be merged at the time of this writing) exposes a legacy_renum_only which was previously an internal flag, but is now exposed in order to create graphs specifically for use with algos that use pylibcugraph Graph objects stored in the cuGraph graph objects.

This is confusing to users not familiar with the implementation details, and could cause problems if users don't understand when they should or shouldn't set it.

For reference: #2394 (comment)


Behavior based on legacy_renum_only setting vs. SG/MG/algo type

SG legacy algoMG legacy algoSG plc algoMG plc algo
legacy_renum_only=TrueERRORERRORoptimal performanceoptimal performance
legacy_renum_only=Falseno errorno errorno error but reduced performance (redundant renumber step)no error but reduced performance (redundant renumber step), and potential hang
@rlratzel rlratzel added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jul 21, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 21, 2022
@rlratzel rlratzel self-assigned this Jul 21, 2022
@rlratzel rlratzel modified the milestones: 22.08, 22.10 Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants